Use string_view to improve safety.

Move into unnamed namespace. Don't hold onto AutoComplete*.
Simplify indexing by 2. Use const.

SC_ORDER_CUSTOM or SC_ORDER_PERFORMSORT and the list is empty.

Shift of unsigned to avoid too much shifting and overflow warnings.
Remove condition that was always true.
Remove suppressions no longer needed.