aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorNeil <nyamatongwe@gmail.com>2026-02-18 13:40:43 +1100
committerNeil <nyamatongwe@gmail.com>2026-02-18 13:40:43 +1100
commit4405f60a2107d3873724930af061a49b03d4b8e7 (patch)
tree32fc07971df5486743d02a268f9d150ecde79326
parent1ffe844d22600a4acd248c14bd0006e000622d93 (diff)
downloadscintilla-mirror-4405f60a2107d3873724930af061a49b03d4b8e7.tar.gz
When a line end is not selected, change the colour of the rectangle that
indicates the line end is selected to white space background instead of previous character's background except for EOL filled style.
-rw-r--r--doc/ScintillaHistory.html4
-rw-r--r--src/EditView.cxx9
2 files changed, 6 insertions, 7 deletions
diff --git a/doc/ScintillaHistory.html b/doc/ScintillaHistory.html
index 45ffeefe9..292f4033c 100644
--- a/doc/ScintillaHistory.html
+++ b/doc/ScintillaHistory.html
@@ -620,6 +620,10 @@
<a href="https://sourceforge.net/p/scintilla/bugs/2491/">Bug #2491</a>.
</li>
<li>
+ When a line end is not selected, change the colour of the rectangle that indicates the line end is selected
+ to white space background instead of previous character's background except for EOL filled style.
+ </li>
+ <li>
On Qt, add const to ScintillaDocument and ScintillaEdit methods.
<a href="https://sourceforge.net/p/scintilla/bugs/2494/">Bug #2494</a>.
</li>
diff --git a/src/EditView.cxx b/src/EditView.cxx
index 9ebf9a759..b2895d97c 100644
--- a/src/EditView.cxx
+++ b/src/EditView.cxx
@@ -1107,13 +1107,8 @@ void EditView::DrawEOL(Surface *surface, const EditModel &model, const ViewStyle
base = selectionBack;
} else if (background) {
base = *background;
- } else {
- const Style &styleLast = vsDraw.styles[ll->LastStyle()];
- if (!lastLine || styleLast.eolFilled) {
- // TODO: the !lastLine|| seems wrong but it has been included
- // since at least 2009. https://sourceforge.net/p/scintilla/code/ci/1b042b53bbde/
- base = styleLast.back;
- }
+ } else if (const Style &styleLast = vsDraw.styles[ll->LastStyle()]; styleLast.eolFilled) {
+ base = styleLast.back;
}
surface->FillRectangleAligned(rcEOLIsSelected, Fill(base.Opaque()));
if (drawEOLSelection && (vsDraw.selection.layer != Layer::Base)) {