aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorNeil <nyamatongwe@gmail.com>2015-05-13 09:32:04 +1000
committerNeil <nyamatongwe@gmail.com>2015-05-13 09:32:04 +1000
commit6cfb4d4ff01f6b7aaa954166f741b5f32ed50dfe (patch)
treea0d0e2c998d773874fb1063297b11c830bda0a11
parent6ac20a5f1e5ceb897268755ce2a650e255d9f103 (diff)
downloadscintilla-mirror-6cfb4d4ff01f6b7aaa954166f741b5f32ed50dfe.tar.gz
Make single argument constructors explicit where simple to avoid possibility of
unintended conversions.
-rw-r--r--qt/ScintillaEdit/ScintillaDocument.cpp2
-rw-r--r--qt/ScintillaEditBase/PlatQt.cpp4
-rw-r--r--qt/ScintillaEditBase/ScintillaEditBase.h2
-rw-r--r--qt/ScintillaEditBase/ScintillaQt.cpp2
-rw-r--r--qt/ScintillaEditBase/ScintillaQt.h2
5 files changed, 6 insertions, 6 deletions
diff --git a/qt/ScintillaEdit/ScintillaDocument.cpp b/qt/ScintillaEdit/ScintillaDocument.cpp
index 67cf5f722..58f4f6a24 100644
--- a/qt/ScintillaEdit/ScintillaDocument.cpp
+++ b/qt/ScintillaEdit/ScintillaDocument.cpp
@@ -36,7 +36,7 @@ using namespace Scintilla;
class WatcherHelper : public DocWatcher {
ScintillaDocument *owner;
public:
- WatcherHelper(ScintillaDocument *owner_);
+ explicit WatcherHelper(ScintillaDocument *owner_);
virtual ~WatcherHelper();
void NotifyModifyAttempt(Document *doc, void *userData);
diff --git a/qt/ScintillaEditBase/PlatQt.cpp b/qt/ScintillaEditBase/PlatQt.cpp
index 38f1d16d1..71bdae792 100644
--- a/qt/ScintillaEditBase/PlatQt.cpp
+++ b/qt/ScintillaEditBase/PlatQt.cpp
@@ -780,7 +780,7 @@ private:
class ListWidget : public QListWidget {
public:
- ListWidget(QWidget *parent);
+ explicit ListWidget(QWidget *parent);
virtual ~ListWidget();
void setDoubleClickAction(CallBackAction action, void *data);
@@ -1110,7 +1110,7 @@ class DynamicLibraryImpl : public DynamicLibrary {
protected:
QLibrary *lib;
public:
- DynamicLibraryImpl(const char *modulePath) {
+ explicit DynamicLibraryImpl(const char *modulePath) {
QString path = QString::fromUtf8(modulePath);
lib = new QLibrary(path);
}
diff --git a/qt/ScintillaEditBase/ScintillaEditBase.h b/qt/ScintillaEditBase/ScintillaEditBase.h
index 9835b89f5..c4453334c 100644
--- a/qt/ScintillaEditBase/ScintillaEditBase.h
+++ b/qt/ScintillaEditBase/ScintillaEditBase.h
@@ -43,7 +43,7 @@ class EXPORT_IMPORT_API ScintillaEditBase : public QAbstractScrollArea {
Q_OBJECT
public:
- ScintillaEditBase(QWidget *parent = 0);
+ explicit ScintillaEditBase(QWidget *parent = 0);
virtual ~ScintillaEditBase();
virtual sptr_t send(
diff --git a/qt/ScintillaEditBase/ScintillaQt.cpp b/qt/ScintillaEditBase/ScintillaQt.cpp
index 7cb72e319..3b7db8002 100644
--- a/qt/ScintillaEditBase/ScintillaQt.cpp
+++ b/qt/ScintillaEditBase/ScintillaQt.cpp
@@ -498,7 +498,7 @@ QByteArray ScintillaQt::BytesForDocument(const QString &text) const
class CaseFolderDBCS : public CaseFolderTable {
QTextCodec *codec;
public:
- CaseFolderDBCS(QTextCodec *codec_) : codec(codec_) {
+ explicit CaseFolderDBCS(QTextCodec *codec_) : codec(codec_) {
StandardASCII();
}
virtual size_t Fold(char *folded, size_t sizeFolded, const char *mixed, size_t lenMixed) {
diff --git a/qt/ScintillaEditBase/ScintillaQt.h b/qt/ScintillaEditBase/ScintillaQt.h
index a681d150f..c83411edf 100644
--- a/qt/ScintillaEditBase/ScintillaQt.h
+++ b/qt/ScintillaEditBase/ScintillaQt.h
@@ -72,7 +72,7 @@ class ScintillaQt : public QObject, public ScintillaBase {
Q_OBJECT
public:
- ScintillaQt(QAbstractScrollArea *parent);
+ explicit ScintillaQt(QAbstractScrollArea *parent);
virtual ~ScintillaQt();
signals: