aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorJiří Techet <techet@gmail.com>2025-09-29 08:52:52 +1000
committerJiří Techet <techet@gmail.com>2025-09-29 08:52:52 +1000
commitad271a183c03407e3e8ba92c23f0deb00dc92709 (patch)
tree6bf7fad52369aa2d4308d76a2f3c139f4d925a03
parentcde12528a7e587833926354b88ad1974aedaf103 (diff)
downloadscintilla-mirror-ad271a183c03407e3e8ba92c23f0deb00dc92709.tar.gz
Bug [#2486]. Eliminate special macOS default calltip color
There doesn't seem to be any editor using this color these days and the result looks alien on the platform. Using grey on white looks much more native for the platform.
-rw-r--r--doc/ScintillaHistory.html4
-rw-r--r--src/CallTip.cxx6
2 files changed, 4 insertions, 6 deletions
diff --git a/doc/ScintillaHistory.html b/doc/ScintillaHistory.html
index e8b55793b..254178ae7 100644
--- a/doc/ScintillaHistory.html
+++ b/doc/ScintillaHistory.html
@@ -610,6 +610,10 @@
Enlarge bitmap to avoid visible blank background between items.
<a href="https://sourceforge.net/p/scintilla/bugs/2482/">Bug #2482</a>.
</li>
+ <li>
+ On Cocoa, use same default calltip colours as other platforms for consistency.
+ <a href="https://sourceforge.net/p/scintilla/bugs/2486/">Bug #2486</a>.
+ </li>
</ul>
<h3>
<a href="https://www.scintilla.org/scintilla557.zip">Release 5.5.7</a>
diff --git a/src/CallTip.cxx b/src/CallTip.cxx
index 2be23e898..c803cb69d 100644
--- a/src/CallTip.cxx
+++ b/src/CallTip.cxx
@@ -40,15 +40,9 @@ size_t Chunk::Length() const noexcept {
namespace {
-#ifdef __APPLE__
-// Archaic macOS colours for the default: black on light yellow
-constexpr ColourRGBA colourTextAndArrow(black);
-constexpr ColourRGBA colourBackground(0xff, 0xff, 0xc6);
-#else
// Grey on white
constexpr ColourRGBA colourTextAndArrow(0x80, 0x80, 0x80);
constexpr ColourRGBA colourBackground(white);
-#endif
constexpr ColourRGBA silver(0xc0, 0xc0, 0xc0);