aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/ScintillaBase.cxx
diff options
context:
space:
mode:
authorMitchell Foral <unknown>2023-02-14 17:50:25 +1100
committerMitchell Foral <unknown>2023-02-14 17:50:25 +1100
commit00fe0093156d19a55d5eefcf67dbbe8a73640933 (patch)
tree88431d13aa3a39f46124688051e1ba7203250320 /src/ScintillaBase.cxx
parent925f71967990878b61cbfc088e0a369dc2a61673 (diff)
downloadscintilla-mirror-00fe0093156d19a55d5eefcf67dbbe8a73640933.tar.gz
Fix a potential crash with autocompletion list fill-ups where a SCN_CHARADDED
handler retriggered an autocompletion list, but with no items that match the typed character.
Diffstat (limited to 'src/ScintillaBase.cxx')
-rw-r--r--src/ScintillaBase.cxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ScintillaBase.cxx b/src/ScintillaBase.cxx
index 110e06489..f8b3aefda 100644
--- a/src/ScintillaBase.cxx
+++ b/src/ScintillaBase.cxx
@@ -83,7 +83,7 @@ void ScintillaBase::InsertCharacter(std::string_view sv, CharacterSource charSou
if (!isFillUp) {
Editor::InsertCharacter(sv, charSource);
}
- if (acActive) {
+ if (acActive && ac.Active()) { // if it was and still is active
AutoCompleteCharacterAdded(sv[0]);
// For fill ups add the character after the autocompletion has
// triggered so containers see the key so can display a calltip.