diff options
author | Neil <nyamatongwe@gmail.com> | 2013-07-25 17:43:00 +1000 |
---|---|---|
committer | Neil <nyamatongwe@gmail.com> | 2013-07-25 17:43:00 +1000 |
commit | f41794f988b72fd4d7ac905f939ff868ba94e991 (patch) | |
tree | fc12354ce053aef134030bb3ebceaf477c0666b4 /src | |
parent | 28af18d2d1226689923cadd7030d2f085253e6a3 (diff) | |
download | scintilla-mirror-f41794f988b72fd4d7ac905f939ff868ba94e991.tar.gz |
Minor changes to avoid warnings from Coverity.
Diffstat (limited to 'src')
-rw-r--r-- | src/Editor.cxx | 9 | ||||
-rw-r--r-- | src/Editor.h | 2 | ||||
-rw-r--r-- | src/ScintillaBase.cxx | 2 |
3 files changed, 7 insertions, 6 deletions
diff --git a/src/Editor.cxx b/src/Editor.cxx index 859ae180c..c13a5fd9d 100644 --- a/src/Editor.cxx +++ b/src/Editor.cxx @@ -200,6 +200,8 @@ Editor::Editor() { theEdge = 0; paintState = notPainting; + paintAbandonedByStyling = false; + paintingAllText = false; willRedrawAll = false; modEventMask = SC_MODEVENTMASKALL; @@ -2500,11 +2502,9 @@ void Editor::DrawWrapMarker(Surface *surface, PRectangle rcPlace, int w = rcPlace.right - rcPlace.left - xa - 1; bool xStraight = isEndMarker; // x-mirrored symbol for start marker - bool yStraight = true; - //bool yStraight= isEndMarker; // comment in for start marker y-mirrowed int x0 = xStraight ? rcPlace.left : rcPlace.right - 1; - int y0 = yStraight ? rcPlace.top : rcPlace.bottom - 1; + int y0 = rcPlace.top; int dy = (rcPlace.bottom - rcPlace.top) / 5; int y = (rcPlace.bottom - rcPlace.top) / 2 + dy; @@ -2522,7 +2522,7 @@ void Editor::DrawWrapMarker(Surface *surface, PRectangle rcPlace, surface->LineTo(xBase + xDir * xRelative, yBase + yDir * yRelative); } }; - Relative rel = {surface, x0, xStraight ? 1 : -1, y0, yStraight ? 1 : -1}; + Relative rel = {surface, x0, xStraight ? 1 : -1, y0, 1}; // arrow head rel.MoveTo(xa, y); @@ -9151,6 +9151,7 @@ sptr_t Editor::WndProc(unsigned int iMessage, uptr_t wParam, sptr_t lParam) { sel.selType = Selection::selStream; } InvalidateSelection(sel.RangeMain(), true); + break; } case SCI_GETSELECTIONMODE: switch (sel.selType) { diff --git a/src/Editor.h b/src/Editor.h index d1879d6ec..52d38afc4 100644 --- a/src/Editor.h +++ b/src/Editor.h @@ -525,7 +525,7 @@ protected: // ScintillaBase subclass needs access to much of Editor void ContainerNeedsUpdate(int flags); void PageMove(int direction, Selection::selTypes sel=Selection::noSel, bool stuttered = false); - enum { cmSame, cmUpper, cmLower } caseMap; + enum { cmSame, cmUpper, cmLower }; virtual std::string CaseMapString(const std::string &s, int caseMapping); void ChangeCaseOfSelection(int caseMapping); void LineTranspose(); diff --git a/src/ScintillaBase.cxx b/src/ScintillaBase.cxx index 05768799d..814eac726 100644 --- a/src/ScintillaBase.cxx +++ b/src/ScintillaBase.cxx @@ -262,7 +262,7 @@ void ScintillaBase::AutoCompleteStart(int lenEntered, const char *list) { ac.lb->SetAverageCharWidth(aveCharWidth); ac.lb->SetDoubleClickAction(AutoCompleteDoubleClick, this); - ac.SetList(list); + ac.SetList(list ? list : ""); // Fiddle the position of the list so it is right next to the target and wide enough for all its strings PRectangle rcList = ac.lb->GetDesiredRect(); |