aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
-rw-r--r--doc/ScintillaHistory.html13
-rw-r--r--qt/ScintillaEdit/ScintillaDocument.cpp5
-rw-r--r--qt/ScintillaEdit/ScintillaDocument.h1
-rw-r--r--src/Document.cxx8
-rw-r--r--src/Document.h2
-rw-r--r--src/Editor.cxx3
-rw-r--r--src/Editor.h1
-rw-r--r--src/ScintillaBase.cxx4
-rw-r--r--src/ScintillaBase.h1
9 files changed, 13 insertions, 25 deletions
diff --git a/doc/ScintillaHistory.html b/doc/ScintillaHistory.html
index e24bd5dc6..7a4b5b9bc 100644
--- a/doc/ScintillaHistory.html
+++ b/doc/ScintillaHistory.html
@@ -577,6 +577,19 @@
</table>
<h2>Releases</h2>
<h3>
+ <a href="https://www.scintilla.org/scintilla531.zip">Release 5.3.1</a>
+ </h3>
+ <ul>
+ <li>
+ Released 27 August 2022.
+ </li>
+ <li>
+ Removed NotifyLexerChanged notification from DocWatcher.
+ This is a private interface but could be used by independent platform layers
+ and was exposed by ScintillaDocument in the Qt implementation of ScintillaEdit.
+ </li>
+ </ul>
+ <h3>
<a href="https://www.scintilla.org/scintilla530.zip">Release 5.3.0</a>
</h3>
<ul>
diff --git a/qt/ScintillaEdit/ScintillaDocument.cpp b/qt/ScintillaEdit/ScintillaDocument.cpp
index 251a5e557..f14830010 100644
--- a/qt/ScintillaEdit/ScintillaDocument.cpp
+++ b/qt/ScintillaEdit/ScintillaDocument.cpp
@@ -54,7 +54,6 @@ public:
void NotifyModified(Document *doc, DocModification mh, void *userData) override;
void NotifyDeleted(Document *doc, void *userData) noexcept override;
void NotifyStyleNeeded(Document *doc, void *userData, Sci::Position endPos) override;
- void NotifyLexerChanged(Document *doc, void *userData) override;
void NotifyErrorOccurred(Document *doc, void *userData, Status status) override;
};
@@ -85,10 +84,6 @@ void WatcherHelper::NotifyStyleNeeded(Document *, void *, Sci::Position endPos)
emit owner->style_needed(endPos);
}
-void WatcherHelper::NotifyLexerChanged(Document *, void *) {
- emit owner->lexer_changed();
-}
-
void WatcherHelper::NotifyErrorOccurred(Document *, void *, Status status) {
emit owner->error_occurred(static_cast<int>(status));
}
diff --git a/qt/ScintillaEdit/ScintillaDocument.h b/qt/ScintillaEdit/ScintillaDocument.h
index 9a28689b6..579990781 100644
--- a/qt/ScintillaEdit/ScintillaDocument.h
+++ b/qt/ScintillaEdit/ScintillaDocument.h
@@ -82,7 +82,6 @@ signals:
void modified(int position, int modification_type, const QByteArray &text, int length,
int linesAdded, int line, int foldLevelNow, int foldLevelPrev);
void style_needed(int pos);
- void lexer_changed();
void error_occurred(int status);
friend class ::WatcherHelper;
diff --git a/src/Document.cxx b/src/Document.cxx
index 5e2613bdf..ada7f4436 100644
--- a/src/Document.cxx
+++ b/src/Document.cxx
@@ -58,7 +58,6 @@ LexInterface::~LexInterface() noexcept = default;
void LexInterface::SetInstance(ILexer5 *instance_) {
instance.reset(instance_);
- pdoc->LexerChanged();
}
void LexInterface::Colourise(Sci::Position start, Sci::Position end) {
@@ -2432,13 +2431,6 @@ void Document::StyleToAdjustingLineDuration(Sci::Position pos) {
durationStyleOneByte.AddSample(pos - stylingStart, epStyling.Duration());
}
-void Document::LexerChanged() {
- // Tell the watchers the lexer has changed.
- for (const WatcherWithUserData &watcher : watchers) {
- watcher.watcher->NotifyLexerChanged(this, watcher.userData);
- }
-}
-
LexInterface *Document::GetLexInterface() const noexcept {
return pli.get();
}
diff --git a/src/Document.h b/src/Document.h
index 7daaf0f52..f08e0a302 100644
--- a/src/Document.h
+++ b/src/Document.h
@@ -484,7 +484,6 @@ public:
Sci::Position GetEndStyled() const noexcept { return endStyled; }
void EnsureStyledTo(Sci::Position pos);
void StyleToAdjustingLineDuration(Sci::Position pos);
- void LexerChanged();
int GetStyleClock() const noexcept { return styleClock; }
void IncrementStyleClock() noexcept;
void SCI_METHOD DecorationSetCurrentIndicator(int indicator) override;
@@ -621,7 +620,6 @@ public:
virtual void NotifyModified(Document *doc, DocModification mh, void *userData) = 0;
virtual void NotifyDeleted(Document *doc, void *userData) noexcept = 0;
virtual void NotifyStyleNeeded(Document *doc, void *userData, Sci::Position endPos) = 0;
- virtual void NotifyLexerChanged(Document *doc, void *userData) = 0;
virtual void NotifyErrorOccurred(Document *doc, void *userData, Scintilla::Status status) = 0;
};
diff --git a/src/Editor.cxx b/src/Editor.cxx
index 8e8de16b1..32a63f14a 100644
--- a/src/Editor.cxx
+++ b/src/Editor.cxx
@@ -2379,9 +2379,6 @@ void Editor::NotifyStyleNeeded(Document *, void *, Sci::Position endStyleNeeded)
NotifyStyleToNeeded(endStyleNeeded);
}
-void Editor::NotifyLexerChanged(Document *, void *) {
-}
-
void Editor::NotifyErrorOccurred(Document *, void *, Status status) {
errorStatus = status;
}
diff --git a/src/Editor.h b/src/Editor.h
index a30edff90..297590f47 100644
--- a/src/Editor.h
+++ b/src/Editor.h
@@ -471,7 +471,6 @@ protected: // ScintillaBase subclass needs access to much of Editor
void NotifyModified(Document *document, DocModification mh, void *userData) override;
void NotifyDeleted(Document *document, void *userData) noexcept override;
void NotifyStyleNeeded(Document *doc, void *userData, Sci::Position endStyleNeeded) override;
- void NotifyLexerChanged(Document *doc, void *userData) override;
void NotifyErrorOccurred(Document *doc, void *userData, Scintilla::Status status) override;
void NotifyMacroRecord(Scintilla::Message iMessage, Scintilla::uptr_t wParam, Scintilla::sptr_t lParam);
diff --git a/src/ScintillaBase.cxx b/src/ScintillaBase.cxx
index 979a8b07f..e72f1b1d6 100644
--- a/src/ScintillaBase.cxx
+++ b/src/ScintillaBase.cxx
@@ -809,10 +809,6 @@ void ScintillaBase::NotifyStyleToNeeded(Sci::Position endStyleNeeded) {
Editor::NotifyStyleToNeeded(endStyleNeeded);
}
-void ScintillaBase::NotifyLexerChanged(Document *, void *) {
- vs.EnsureStyle(0xff);
-}
-
sptr_t ScintillaBase::WndProc(Message iMessage, uptr_t wParam, sptr_t lParam) {
switch (iMessage) {
case Message::AutoCShow:
diff --git a/src/ScintillaBase.h b/src/ScintillaBase.h
index 47e24796d..3cfad8684 100644
--- a/src/ScintillaBase.h
+++ b/src/ScintillaBase.h
@@ -82,7 +82,6 @@ protected:
void RightButtonDownWithModifiers(Point pt, unsigned int curTime, Scintilla::KeyMod modifiers) override;
void NotifyStyleToNeeded(Sci::Position endStyleNeeded) override;
- void NotifyLexerChanged(Document *doc, void *userData) override;
public:
~ScintillaBase() override;