From 1df9c8ad39efea4595abfcc9a7305b72a4cf7565 Mon Sep 17 00:00:00 2001 From: Justin Dailey Date: Sat, 1 Jul 2017 12:36:00 +1000 Subject: Include the 'updated' flags in the updateUi signal. Don't send updateUi for focus in. --- doc/ScintillaHistory.html | 7 ++++++- qt/ScintillaEditBase/ScintillaEditBase.cpp | 3 +-- qt/ScintillaEditBase/ScintillaEditBase.h | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/ScintillaHistory.html b/doc/ScintillaHistory.html index a2f255b16..f84075717 100644 --- a/doc/ScintillaHistory.html +++ b/doc/ScintillaHistory.html @@ -498,7 +498,7 @@ Morten Brørup Alexey Denisov - jedailey + Justin Dailey oirfeodent A-R-C-A @@ -562,6 +562,11 @@ Bug #1949.
  • + On Qt, the updateUi signal includes the 'updated' flags. + No updateUi signal is sent for focus in events. + These changes make Qt behave more like the other platforms. +
  • +
  • On Qt, mouse tracking is reenabled when the window is reshown. Bug #1948.
  • diff --git a/qt/ScintillaEditBase/ScintillaEditBase.cpp b/qt/ScintillaEditBase/ScintillaEditBase.cpp index 519db5468..dabdce105 100644 --- a/qt/ScintillaEditBase/ScintillaEditBase.cpp +++ b/qt/ScintillaEditBase/ScintillaEditBase.cpp @@ -181,7 +181,6 @@ void ScintillaEditBase::wheelEvent(QWheelEvent *event) void ScintillaEditBase::focusInEvent(QFocusEvent *event) { sqt->SetFocusState(true); - emit updateUi(); QAbstractScrollArea::focusInEvent(event); } @@ -701,7 +700,7 @@ void ScintillaEditBase::notifyParent(SCNotification scn) break; case SCN_UPDATEUI: - emit updateUi(); + emit updateUi(scn.updated); break; case SCN_MODIFIED: diff --git a/qt/ScintillaEditBase/ScintillaEditBase.h b/qt/ScintillaEditBase/ScintillaEditBase.h index b1151c55d..8ca05da46 100644 --- a/qt/ScintillaEditBase/ScintillaEditBase.h +++ b/qt/ScintillaEditBase/ScintillaEditBase.h @@ -86,7 +86,7 @@ signals: void modifyAttemptReadOnly(); void key(int key); void doubleClick(int position, int line); - void updateUi(); + void updateUi(int updated); void modified(int type, int position, int length, int linesAdded, const QByteArray &text, int line, int foldNow, int foldPrev); void macroRecord(int message, uptr_t wParam, sptr_t lParam); -- cgit v1.2.3