From 24b0d88f4d88ba83c52a8588e49c5ea597093618 Mon Sep 17 00:00:00 2001 From: Neil Date: Sun, 28 Apr 2019 10:20:26 +1000 Subject: Backport: Fix analysis warnings for GlobalMemory class. Backport of changeset 7484:e176cb9f97b7. --- win32/ScintillaWin.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/win32/ScintillaWin.cxx b/win32/ScintillaWin.cxx index a9361b157..efa0520f8 100644 --- a/win32/ScintillaWin.cxx +++ b/win32/ScintillaWin.cxx @@ -2199,7 +2199,7 @@ public: GlobalMemory &operator=(const GlobalMemory &) = delete; GlobalMemory &operator=(GlobalMemory &&) = delete; ~GlobalMemory() { - PLATFORM_ASSERT(!ptr); + assert(!ptr); assert(!hand); } void Allocate(size_t bytes) noexcept { @@ -2209,15 +2209,15 @@ public: ptr = ::GlobalLock(hand); } } - HGLOBAL Unlock() { - PLATFORM_ASSERT(ptr); + HGLOBAL Unlock() noexcept { + assert(ptr); HGLOBAL handCopy = hand; ::GlobalUnlock(hand); ptr = nullptr; - hand = 0; + hand = {}; return handCopy; } - void SetClip(UINT uFormat) { + void SetClip(UINT uFormat) noexcept { ::SetClipboardData(uFormat, Unlock()); } operator bool() const noexcept { -- cgit v1.2.3