From 87ad00ce89284e66fc818ce60c8109bbfa047329 Mon Sep 17 00:00:00 2001
From: Neil <nyamatongwe@gmail.com>
Date: Thu, 28 Mar 2019 08:17:18 +1100
Subject: Bug [#2087]. Fix flicker when inserting primary selection on GTK.

---
 doc/ScintillaHistory.html |  4 +++
 gtk/ScintillaGTK.cxx      | 68 ++++++++++++++++++++++++++++-------------------
 gtk/ScintillaGTK.h        |  4 +++
 3 files changed, 48 insertions(+), 28 deletions(-)

diff --git a/doc/ScintillaHistory.html b/doc/ScintillaHistory.html
index 381dc4ecd..6f08fe033 100644
--- a/doc/ScintillaHistory.html
+++ b/doc/ScintillaHistory.html
@@ -571,6 +571,10 @@
 	Implement high-priority idle on Win32 to make redraw smoother and more efficient.
 	</li>
  	<li>
+	Fix flicker when inserting primary selection on GTK.
+	<a href="https://sourceforge.net/p/scintilla/bugs/2087/">Bug #2087</a>.
+	</li>
+ 	<li>
 	Avoid potential long hangs with idle styling for huge documents on Cocoa and GTK.
 	</li>
     <ul>
diff --git a/gtk/ScintillaGTK.cxx b/gtk/ScintillaGTK.cxx
index f213c0097..ccf2498fa 100644
--- a/gtk/ScintillaGTK.cxx
+++ b/gtk/ScintillaGTK.cxx
@@ -1262,37 +1262,47 @@ void ScintillaGTK::Copy() {
 	}
 }
 
-void ScintillaGTK::Paste() {
-	atomSought = atomUTF8;
-	GtkClipboard *clipBoard =
-		gtk_widget_get_clipboard(GTK_WIDGET(PWidget(wMain)), atomClipboard);
-	if (clipBoard == nullptr)
-		return;
+namespace {
 
-	// helper class for the asynchronous paste not to risk calling in a destroyed ScintillaGTK
-	class Helper : GObjectWatcher {
-		ScintillaGTK *sci;
+// Helper class for the asynchronous paste not to risk calling in a destroyed ScintillaGTK
 
-		void Destroyed() override {
-			sci = nullptr;
-		}
+class SelectionReceiver : GObjectWatcher {
+	ScintillaGTK *sci;
 
-	public:
-		Helper(ScintillaGTK *sci_) :
-			GObjectWatcher(G_OBJECT(PWidget(sci_->wMain))),
-			sci(sci_) {
-		}
+	void Destroyed() override {
+		sci = nullptr;
+	}
 
-		static void ClipboardReceived(GtkClipboard *, GtkSelectionData *selection_data, gpointer data) {
-			Helper *self = static_cast<Helper *>(data);
-			if (self->sci) {
-				self->sci->ReceivedSelection(selection_data);
-			}
-			delete self;
+public:
+	SelectionReceiver(ScintillaGTK *sci_) :
+		GObjectWatcher(G_OBJECT(sci_->MainObject())),
+		sci(sci_) {
+	}
+
+	static void ClipboardReceived(GtkClipboard *, GtkSelectionData *selection_data, gpointer data) {
+		SelectionReceiver *self = static_cast<SelectionReceiver *>(data);
+		if (self->sci) {
+			self->sci->ReceivedSelection(selection_data);
 		}
-	};
+		delete self;
+	}
+};
+
+}
+
+void ScintillaGTK::RequestSelection(GdkAtom atomSelection) {
+	atomSought = atomUTF8;
+	GtkClipboard *clipBoard =
+		gtk_widget_get_clipboard(GTK_WIDGET(PWidget(wMain)), atomSelection);
+	if (clipBoard) {
+		gtk_clipboard_request_contents(clipBoard, atomSought,
+					       SelectionReceiver::ClipboardReceived,
+					       new SelectionReceiver(this));
+	}
+}
 
-	gtk_clipboard_request_contents(clipBoard, atomSought, Helper::ClipboardReceived, new Helper(this));
+void ScintillaGTK::Paste() {
+	RequestSelection(atomClipboard);
 }
 
 void ScintillaGTK::CreateCallTipWindow(PRectangle rc) {
@@ -1423,6 +1433,10 @@ void ScintillaGTK::GetGtkSelectionText(GtkSelectionData *selectionData, Selectio
 	}
 }
 
+GObject *ScintillaGTK::MainObject() const noexcept {
+	return G_OBJECT(PWidget(wMain));
+}
+
 void ScintillaGTK::ReceivedSelection(GtkSelectionData *selection_data) {
 	try {
 		if ((SelectionOfGSD(selection_data) == atomClipboard) ||
@@ -1737,9 +1751,7 @@ gint ScintillaGTK::PressThis(GdkEventButton *event) {
 
 			sel.Clear();
 			SetSelection(pos, pos);
-			atomSought = atomUTF8;
-			gtk_selection_convert(GTK_WIDGET(PWidget(wMain)), GDK_SELECTION_PRIMARY,
-					      atomSought, event->time);
+			RequestSelection(GDK_SELECTION_PRIMARY);
 		} else if (event->button == 3) {
 			if (!PointInSelection(pt))
 				SetEmptySelection(PositionFromLocation(pt));
diff --git a/gtk/ScintillaGTK.h b/gtk/ScintillaGTK.h
index 501903b42..c175192f9 100644
--- a/gtk/ScintillaGTK.h
+++ b/gtk/ScintillaGTK.h
@@ -127,13 +127,17 @@ private:
 	int KeyDefault(int key, int modifiers) override;
 	void CopyToClipboard(const SelectionText &selectedText) override;
 	void Copy() override;
+	void RequestSelection(GdkAtom atomSelection);
 	void Paste() override;
 	void CreateCallTipWindow(PRectangle rc) override;
 	void AddToPopUp(const char *label, int cmd = 0, bool enabled = true) override;
 	bool OwnPrimarySelection();
 	void ClaimSelection() override;
 	void GetGtkSelectionText(GtkSelectionData *selectionData, SelectionText &selText);
+public:	// Public for SelectionReceiver
+	GObject *MainObject() const noexcept;
 	void ReceivedSelection(GtkSelectionData *selection_data);
+private:
 	void ReceivedDrop(GtkSelectionData *selection_data);
 	static void GetSelection(GtkSelectionData *selection_data, guint info, SelectionText *text);
 	void StoreOnClipboard(SelectionText *clipText);
-- 
cgit v1.2.3


From f26ce8da060279b8c6be63e29dac6f339bd65be4 Mon Sep 17 00:00:00 2001
From: Neil <nyamatongwe@gmail.com>
Date: Thu, 28 Mar 2019 08:25:55 +1100
Subject: Use standard GDK_SELECTION_CLIPBOARD instead of interning
 "CLIPBOARD".

---
 gtk/ScintillaGTK.cxx | 8 +++-----
 gtk/ScintillaGTK.h   | 1 -
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/gtk/ScintillaGTK.cxx b/gtk/ScintillaGTK.cxx
index ccf2498fa..9d6fa275f 100644
--- a/gtk/ScintillaGTK.cxx
+++ b/gtk/ScintillaGTK.cxx
@@ -131,7 +131,6 @@ enum {
 	TARGET_URI
 };
 
-GdkAtom ScintillaGTK::atomClipboard = nullptr;
 GdkAtom ScintillaGTK::atomUTF8 = nullptr;
 GdkAtom ScintillaGTK::atomString = nullptr;
 GdkAtom ScintillaGTK::atomUriList = nullptr;
@@ -1302,7 +1301,7 @@ void ScintillaGTK::RequestSelection(GdkAtom atomSelection) {
 }
 
 void ScintillaGTK::Paste() {
-	RequestSelection(atomClipboard);
+	RequestSelection(GDK_SELECTION_CLIPBOARD);
 }
 
 void ScintillaGTK::CreateCallTipWindow(PRectangle rc) {
@@ -1439,7 +1438,7 @@ GObject *ScintillaGTK::MainObject() const noexcept {
 
 void ScintillaGTK::ReceivedSelection(GtkSelectionData *selection_data) {
 	try {
-		if ((SelectionOfGSD(selection_data) == atomClipboard) ||
+		if ((SelectionOfGSD(selection_data) == GDK_SELECTION_CLIPBOARD) ||
 				(SelectionOfGSD(selection_data) == GDK_SELECTION_PRIMARY)) {
 			if ((atomSought == atomUTF8) && (LengthOfGSD(selection_data) <= 0)) {
 				atomSought = atomString;
@@ -1540,7 +1539,7 @@ void ScintillaGTK::GetSelection(GtkSelectionData *selection_data, guint info, Se
 
 void ScintillaGTK::StoreOnClipboard(SelectionText *clipText) {
 	GtkClipboard *clipBoard =
-		gtk_widget_get_clipboard(GTK_WIDGET(PWidget(wMain)), atomClipboard);
+		gtk_widget_get_clipboard(GTK_WIDGET(PWidget(wMain)), GDK_SELECTION_CLIPBOARD);
 	if (clipBoard == nullptr) // Occurs if widget isn't in a toplevel
 		return;
 
@@ -3032,7 +3031,6 @@ void ScintillaGTK::ClassInit(OBJECT_CLASS *object_class, GtkWidgetClass *widget_
 #ifdef SCI_LEXER
 	Scintilla_LinkLexers();
 #endif
-	atomClipboard = gdk_atom_intern("CLIPBOARD", FALSE);
 	atomUTF8 = gdk_atom_intern("UTF8_STRING", FALSE);
 	atomString = GDK_SELECTION_TYPE_STRING;
 	atomUriList = gdk_atom_intern("text/uri-list", FALSE);
diff --git a/gtk/ScintillaGTK.h b/gtk/ScintillaGTK.h
index c175192f9..27f900455 100644
--- a/gtk/ScintillaGTK.h
+++ b/gtk/ScintillaGTK.h
@@ -36,7 +36,6 @@ class ScintillaGTK : public ScintillaBase {
 
 	GtkWidgetClass *parentClass;
 
-	static GdkAtom atomClipboard;
 	static GdkAtom atomUTF8;
 	static GdkAtom atomString;
 	static GdkAtom atomUriList;
-- 
cgit v1.2.3