From f3e4f3579a6c9ad620cf00ad951cc97cd59be365 Mon Sep 17 00:00:00 2001 From: Zufu Liu Date: Fri, 4 Mar 2022 08:20:05 +1100 Subject: Feature [feature-requests:#1432] Simplify CallTip::SetForeBack with pass by value. --- src/CallTip.cxx | 2 +- src/CallTip.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/CallTip.cxx b/src/CallTip.cxx index 0596214bf..4742f66e4 100644 --- a/src/CallTip.cxx +++ b/src/CallTip.cxx @@ -340,7 +340,7 @@ bool CallTip::UseStyleCallTip() const noexcept { // It might be better to have two access functions for this and to use // them for all settings of colours. -void CallTip::SetForeBack(const ColourRGBA &fore, const ColourRGBA &back) noexcept { +void CallTip::SetForeBack(ColourRGBA fore, ColourRGBA back) noexcept { colourBG = back; colourUnSel = fore; } diff --git a/src/CallTip.h b/src/CallTip.h index 3f0e4f801..f8d294651 100644 --- a/src/CallTip.h +++ b/src/CallTip.h @@ -89,7 +89,7 @@ public: bool UseStyleCallTip() const noexcept; // Modify foreground and background colours - void SetForeBack(const ColourRGBA &fore, const ColourRGBA &back) noexcept; + void SetForeBack(ColourRGBA fore, ColourRGBA back) noexcept; }; } -- cgit v1.2.3