From f51f9797cb8591870d13d1d7d0c5d4d7d009a7ea Mon Sep 17 00:00:00 2001 From: Neil Date: Fri, 6 Oct 2023 12:31:52 +1100 Subject: Fix COPY_INSTEAD_OF_MOVE performance warnings from Coverity. --- src/CallTip.cxx | 2 +- src/CallTip.h | 2 +- win32/PlatWin.cxx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/CallTip.cxx b/src/CallTip.cxx index eea592489..87a2bab06 100644 --- a/src/CallTip.cxx +++ b/src/CallTip.cxx @@ -272,7 +272,7 @@ void CallTip::MouseClick(Point pt) noexcept { } PRectangle CallTip::CallTipStart(Sci::Position pos, Point pt, int textHeight, const char *defn, - int codePage_, Surface *surfaceMeasure, std::shared_ptr font_) { + int codePage_, Surface *surfaceMeasure, const std::shared_ptr &font_) { clickPlace = 0; val = defn; codePage = codePage_; diff --git a/src/CallTip.h b/src/CallTip.h index f8d294651..bd02da7d2 100644 --- a/src/CallTip.h +++ b/src/CallTip.h @@ -71,7 +71,7 @@ public: /// Setup the calltip and return a rectangle of the area required. PRectangle CallTipStart(Sci::Position pos, Point pt, int textHeight, const char *defn, - int codePage_, Surface *surfaceMeasure, std::shared_ptr font_); + int codePage_, Surface *surfaceMeasure, const std::shared_ptr &font_); void CallTipCancel() noexcept; diff --git a/win32/PlatWin.cxx b/win32/PlatWin.cxx index 40302102b..91af4a683 100644 --- a/win32/PlatWin.cxx +++ b/win32/PlatWin.cxx @@ -2671,7 +2671,7 @@ void SurfaceD2D::FlushDrawing() { } void SurfaceD2D::SetRenderingParams(std::shared_ptr renderingParams_) { - renderingParams = renderingParams_; + renderingParams = std::move(renderingParams_); } #endif -- cgit v1.2.3