From e030b1d56785405cb35531758d603be88af9b487 Mon Sep 17 00:00:00 2001 From: Neil Date: Fri, 29 Jul 2022 11:16:28 +1000 Subject: Apply rule-of-zero to delete standard methods where possible as handled by contained types. This allows flexibility as most lower-level data types can be moved and SplitVector and Partitioning of non-move-only types may be copied. CellBuffer still needs destructor due to incomplete type so retains all standard operations. --- src/CellBuffer.cxx | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'src/CellBuffer.cxx') diff --git a/src/CellBuffer.cxx b/src/CellBuffer.cxx index b84372cf2..9a509f2eb 100644 --- a/src/CellBuffer.cxx +++ b/src/CellBuffer.cxx @@ -329,9 +329,6 @@ Action::Action() noexcept { mayCoalesce = false; } -Action::~Action() { -} - void Action::Create(ActionType at_, Sci::Position position_, const char *data_, Sci::Position lenData_, bool mayCoalesce_) { data = nullptr; position = position_; @@ -379,9 +376,6 @@ UndoHistory::UndoHistory() { actions[currentAction].Create(ActionType::start); } -UndoHistory::~UndoHistory() { -} - void UndoHistory::EnsureUndoRoom() { // Have to test that there is room for 2 more actions in the array // as two actions may be created by the calling function @@ -598,8 +592,7 @@ CellBuffer::CellBuffer(bool hasStyles_, bool largeDocument_) : plv = std::make_unique>(); } -CellBuffer::~CellBuffer() { -} +CellBuffer::~CellBuffer() noexcept = default; char CellBuffer::CharAt(Sci::Position position) const noexcept { return substance.ValueAt(position); -- cgit v1.2.3