From e85eee7838814ad178a841527199270e936efd72 Mon Sep 17 00:00:00 2001 From: Zufu Liu Date: Mon, 4 Jul 2022 09:58:26 +1000 Subject: Feature [feature-requests:#1442] Tighter checking of indices avoids handling out-of-bounds in lower layer. Make expressions agree in ApplyStep for clarity. --- src/Document.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Document.cxx') diff --git a/src/Document.cxx b/src/Document.cxx index 54d14cda3..8e80502e0 100644 --- a/src/Document.cxx +++ b/src/Document.cxx @@ -348,7 +348,7 @@ Sci::Line Document::MarkerNext(Sci::Line lineStart, int mask) const noexcept { } int Document::AddMark(Sci::Line line, int markerNum) { - if (line >= 0 && line <= LinesTotal()) { + if (line >= 0 && line < LinesTotal()) { const int prev = Markers()->AddMark(line, markerNum, LinesTotal()); const DocModification mh(ModificationFlags::ChangeMarker, LineStart(line), 0, 0, nullptr, line); NotifyModified(mh); @@ -359,7 +359,7 @@ int Document::AddMark(Sci::Line line, int markerNum) { } void Document::AddMarkSet(Sci::Line line, int valueSet) { - if (line < 0 || line > LinesTotal()) { + if (line < 0 || line >= LinesTotal()) { return; } unsigned int m = valueSet; -- cgit v1.2.3