From 73ae9e3d2ad7fddbe8945deb0647dd7597d58c0a Mon Sep 17 00:00:00 2001 From: Neil Date: Sat, 12 Mar 2022 10:24:52 +1100 Subject: Feature [feature-requests:#1432] Move some surface creation out of headers and make virtual to allow customisation by platform layers. --- src/Editor.h | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) (limited to 'src/Editor.h') diff --git a/src/Editor.h b/src/Editor.h index fd140a800..a430a23d4 100644 --- a/src/Editor.h +++ b/src/Editor.h @@ -592,6 +592,8 @@ protected: // ScintillaBase subclass needs access to much of Editor virtual bool ValidCodePage(int /* codePage */) const { return true; } virtual std::string UTF8FromEncoded(std::string_view encoded) const = 0; virtual std::string EncodedFromUTF8(std::string_view utf8) const = 0; + virtual std::unique_ptr CreateMeasurementSurface() const; + virtual std::unique_ptr CreateDrawingSurface(SurfaceID sid, std::optional technologyOpt = {}) const; Sci::Line WrapCount(Sci::Line line); void AddStyledText(const char *buffer, Sci::Position appendLength); @@ -684,19 +686,11 @@ class AutoSurface { private: std::unique_ptr surf; public: - AutoSurface(const Editor *ed) { - if (ed->wMain.GetID()) { - surf = Surface::Allocate(ed->technology); - surf->Init(ed->wMain.GetID()); - surf->SetMode(ed->CurrentSurfaceMode()); - } + AutoSurface(const Editor *ed) : + surf(ed->CreateMeasurementSurface()) { } - AutoSurface(SurfaceID sid, Editor *ed, std::optional technology = {}) { - if (ed->wMain.GetID()) { - surf = Surface::Allocate(technology ? *technology : ed->technology); - surf->Init(sid, ed->wMain.GetID()); - surf->SetMode(ed->CurrentSurfaceMode()); - } + AutoSurface(SurfaceID sid, Editor *ed, std::optional technology = {}) : + surf(ed->CreateDrawingSurface(sid, technology)) { } // Deleted so AutoSurface objects can not be copied. AutoSurface(const AutoSurface &) = delete; -- cgit v1.2.3