From e751a5dc21c0e46a3a4ff0e91a741429180b6b1f Mon Sep 17 00:00:00 2001
From: nyamatongwe <unknown>
Date: Thu, 6 Nov 2003 11:56:33 +0000
Subject: SelectionText has been holding a terminating NUL but some client code
 was adding an extra NUL. Documented this and avoid adding extra NUL.

---
 src/Editor.cxx | 1 -
 src/Editor.h   | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/Editor.cxx b/src/Editor.cxx
index 2331e64e0..ce606ee00 100644
--- a/src/Editor.cxx
+++ b/src/Editor.cxx
@@ -5487,7 +5487,6 @@ sptr_t Editor::WndProc(unsigned int iMessage, uptr_t wParam, sptr_t lParam) {
 			if (selectedText.len) {
 				for (; iChar < selectedText.len; iChar++)
 					ptr[iChar] = selectedText.s[iChar];
-				ptr[iChar] = '\0';
 			} else {
 				ptr[0] = '\0';
 			}
diff --git a/src/Editor.h b/src/Editor.h
index 6eccb50bd..08c56f7a4 100644
--- a/src/Editor.h
+++ b/src/Editor.h
@@ -126,6 +126,8 @@ public:
 };
 
 /**
+ * Hold a piece of text selected for copying or dragging.
+ * The text is expected to hold a terminating '\0'.
  */
 class SelectionText {
 public:
-- 
cgit v1.2.3