From 77d00274b4e729ba5eac3cda390d6aa9478567ca Mon Sep 17 00:00:00 2001
From: Neil <nyamatongwe@gmail.com>
Date: Tue, 30 Jan 2024 10:11:10 +1100
Subject: Avoid warnings in unit tests with const, nullptr, [[nodiscard]],
 initialisation, and unnamed namespace.

---
 test/unit/testSplitVector.cxx | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'test/unit/testSplitVector.cxx')

diff --git a/test/unit/testSplitVector.cxx b/test/unit/testSplitVector.cxx
index b5559a6af..5125eb55f 100644
--- a/test/unit/testSplitVector.cxx
+++ b/test/unit/testSplitVector.cxx
@@ -37,13 +37,13 @@ TEST_CASE("CompileCopying SplitVector") {
 		SplitVector<int> s2;
 
 		// Copy constructor fails
-		SplitVector<int> sa(s);
+		const SplitVector<int> sa(s);
 		// Copy assignment fails
 		SplitVector<int> sb;
 		sb = s;
 
 		// Move constructor fails
-		SplitVector<int> sc(std::move(s));
+		const SplitVector<int> sc(std::move(s));
 		// Move assignment fails
 		SplitVector<int> sd;
 		sd = (std::move(s2));
@@ -62,7 +62,7 @@ TEST_CASE("CompileCopying SplitVector") {
 #endif
 
 		// Move constructor fails
-		SplitVector<UniqueInt> sc(std::move(s));
+		const SplitVector<UniqueInt> sc(std::move(s));
 		// Move assignment fails
 		SplitVector<UniqueInt> sd;
 		sd = (std::move(s));
@@ -72,7 +72,7 @@ TEST_CASE("CompileCopying SplitVector") {
 
 struct StringSetHolder {
 	SplitVector<std::string> sa;
-	bool Check() const noexcept {
+	[[nodiscard]] bool Check() const noexcept {
 		for (int i = 0; i < sa.Length(); i++) {
 			if (sa[i].empty()) {
 				return false;
-- 
cgit v1.2.3