From 2500ebc8eda4588b3a0cba45484470ea417afbde Mon Sep 17 00:00:00 2001 From: nyamatongwe Date: Thu, 28 Jan 2010 04:50:27 +0000 Subject: Avoiding warnings from cppcheck. Mostly removing bodies of private copy constructors and operator=. Also ensuring initialisation for some fields, reducing scope where possible, and passing by const reference. --- win32/PlatWin.cxx | 4 ++-- win32/ScintillaWin.cxx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'win32') diff --git a/win32/PlatWin.cxx b/win32/PlatWin.cxx index 8ff27011c..71a968541 100644 --- a/win32/PlatWin.cxx +++ b/win32/PlatWin.cxx @@ -372,8 +372,8 @@ class SurfaceImpl : public Surface { void SetFont(Font &font_); // Private so SurfaceImpl objects can not be copied - SurfaceImpl(const SurfaceImpl &) : Surface() {} - SurfaceImpl &operator=(const SurfaceImpl &) { return *this; } + SurfaceImpl(const SurfaceImpl &); + SurfaceImpl &operator=(const SurfaceImpl &); public: SurfaceImpl(); virtual ~SurfaceImpl(); diff --git a/win32/ScintillaWin.cxx b/win32/ScintillaWin.cxx index 1937458d4..47ff0f41a 100644 --- a/win32/ScintillaWin.cxx +++ b/win32/ScintillaWin.cxx @@ -176,9 +176,9 @@ class ScintillaWin : static HINSTANCE hInstance; ScintillaWin(HWND hwnd); - ScintillaWin(const ScintillaWin &) : ScintillaBase() {} + ScintillaWin(const ScintillaWin &); virtual ~ScintillaWin(); - ScintillaWin &operator=(const ScintillaWin &) { return *this; } + ScintillaWin &operator=(const ScintillaWin &); virtual void Initialise(); virtual void Finalise(); -- cgit v1.2.3