diff options
| author | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2024-09-09 23:22:15 +0200 |
|---|---|---|
| committer | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2024-09-10 12:13:38 +0200 |
| commit | adc067ba745cebf2e2a2f9523bc14136ca1d2680 (patch) | |
| tree | 25c96d2f1c6f98a61c9e4efb6ccc07d1a3b350e3 /.github/workflows/nightly.yml | |
| parent | 62ccd355f060d29a46346e08086c7be6de57cdd8 (diff) | |
| download | sciteco-adc067ba745cebf2e2a2f9523bc14136ca1d2680.tar.gz | |
fixed win32 CI and nightly builds (refs #5)
* The libtool wrapper binaries do not pass down UTF-8 strings correctly,
so the Unicode tests failed under some circumstances.
* As we aren't actually linking against any locally-built shared libraries,
we are passing --disable-shared to libtool which inhibts wrapper generation
on win32 and fixes the test suite.
* Also use up to date autotools. This didn't fix anything, though.
* test suite: try writing an Unicode filename as well
* There have been problems doing that on Win32 where UTF-8 was not
correctly passed down from the command line and some Windows API
calls were only working with ANSI filenames etc.
Diffstat (limited to '.github/workflows/nightly.yml')
| -rw-r--r-- | .github/workflows/nightly.yml | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 1bd9321..2e438ef 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -169,7 +169,7 @@ jobs: - name: Install Build Dependencies run: > pacman -S --noconfirm --needed - base-devel autotools mingw-w64-i686-toolchain + base-devel mingw-w64-i686-autotools mingw-w64-i686-toolchain mingw-w64-i686-glib2 mingw-w64-i686-pdcurses groff @@ -188,14 +188,17 @@ jobs: CFLAGS: -O3 -flto CXXFLAGS: -O3 -flto LDFLAGS: -flto + # --disable-shared makes sure that libtool won't create wrapper binaries. + # They are not required and cause problems when running the test suite + # as they don't pass down UTF-8 parameters properly. run: | autoreconf -i mkdir build-wingui build-wincon (cd build-wingui - ../configure --with-interface=pdcurses-gui --enable-html-manual --program-prefix=g \ + ../configure --with-interface=pdcurses-gui --disable-shared --enable-html-manual --program-prefix=g \ PDCURSES_LIBS="-lpdcurses_wingui -lgdi32 -lcomdlg32 -lwinmm") (cd build-wincon - ../configure --with-interface=pdcurses --enable-html-manual \ + ../configure --with-interface=pdcurses --disable-shared --enable-html-manual \ PDCURSES_LIBS="-lpdcurses_wincon -lgdi32 -lwinmm") - name: make @@ -263,7 +266,7 @@ jobs: - name: Install Build Dependencies run: > pacman -S --noconfirm --needed - base-devel autotools mingw-w64-i686-toolchain + base-devel mingw-w64-i686-autotools mingw-w64-i686-toolchain mingw-w64-i686-glib2 mingw-w64-i686-gtk3 groff @@ -273,9 +276,12 @@ jobs: CFLAGS: -O3 -flto CXXFLAGS: -O3 -flto LDFLAGS: -flto + # --disable-shared makes sure that libtool won't create wrapper binaries. + # They are not required and cause problems when running the test suite + # as they don't pass down UTF-8 parameters properly. run: | autoreconf -i - ./configure --with-interface=gtk --enable-html-manual + ./configure --with-interface=gtk --disable-shared --enable-html-manual - name: make run: make -j 2 |