aboutsummaryrefslogtreecommitdiffhomepage
path: root/contrib
diff options
context:
space:
mode:
authorRobin Haberkorn <robin.haberkorn@googlemail.com>2021-10-24 01:15:59 +0300
committerRobin Haberkorn <robin.haberkorn@googlemail.com>2021-10-24 01:35:11 +0300
commitaa00bf10d986bf3a022c33be1cb79fdd4dadf438 (patch)
tree50ba7105aba8c31bd65fa30718391696b5cf5f6a /contrib
parent017200d18f798071d455b6f82ba77189b58c5791 (diff)
downloadsciteco-aa00bf10d986bf3a022c33be1cb79fdd4dadf438.tar.gz
added ./configure --enable-debug and make sure that NDEBUG is defined properly
* This simplifies writing CFLAGS="-g -O0" CXXFLAGS="-g -O0". * We build "release" binaries by default. NDEBUG will now be defined unless you specify --enable-debug. This enables some optimizations that have long been implemented but were never actually active: * SciTECO shuts down faster since it will not explicitly free memory. On the downside, this would complicate memory debugging with Valgrind/memcheck. * dlmalloc is built with -DINSECURE=1 which is supposedly a bit faster. Some compilers also complained about an unportable preprocessor usage which should now be gone. * All CI builds are now with --enable-debug. This will slow them down but ensure that more code is executed and thus tested.
Diffstat (limited to 'contrib')
-rw-r--r--contrib/dlmalloc/Makefile.am6
1 files changed, 4 insertions, 2 deletions
diff --git a/contrib/dlmalloc/Makefile.am b/contrib/dlmalloc/Makefile.am
index f9e35dd..223ed13 100644
--- a/contrib/dlmalloc/Makefile.am
+++ b/contrib/dlmalloc/Makefile.am
@@ -8,8 +8,10 @@
# for increased portability. There is also AC_LIBOBJ, but it's usually for defining sources of
# replacement libraries.
-AM_CPPFLAGS = -DINSECURE='defined(NDEBUG)' -DNO_MALLINFO=1 -DNO_MALLOC_STATS=1 \
- -DUSE_LOCKS=1 -DUSE_DL_PREFIX
+AM_CPPFLAGS = -DNO_MALLINFO=1 -DNO_MALLOC_STATS=1 -DUSE_LOCKS=1 -DUSE_DL_PREFIX
+if !DEBUG
+AM_CPPFLAGS += -DINSECURE=1
+endif
# FIXME: This optimization is still broken as of GCC v9.3.0.
# This is a known GCC bug, triggered by memset() in calloc().