teco_string_t is now passed by value like a scalar if the callee isn't expected to modify it

* When passing a struct that should not be modified, I usually use a const pointer.
* Strings however are small 2-word objects and they are often now already passed via separate
  `gchar*` and gsize parameters. So it is consistent to pass teco_string_t by value as well.
  A teco_string_t will usually fit into registers just like a pointer.
* It's now obvious which function just _uses_ and which function _modifies_ a string.
  There is also no chance to pass a NULL pointer to those functions.

1 files changed, 7 insertions, 7 deletions

diff --git a/src/glob.c b/src/glob.c
index d2bf713..85f36e5 100644
--- a/src/glob.c
+++ b/src/glob.c
@@ -305,13 +305,13 @@ teco_globber_compile_pattern(const gchar *pattern)
  */
 
 static teco_state_t *
-teco_state_glob_pattern_done(teco_machine_main_t *ctx, const teco_string_t *str, GError **error)
+teco_state_glob_pattern_done(teco_machine_main_t *ctx, teco_string_t str, GError **error)
 {
 	if (ctx->flags.mode > TECO_MODE_NORMAL)
 		return &teco_state_glob_filename;
 
-	if (str->len > 0) {
-		g_autofree gchar *filename = teco_file_expand_path(str->data);
+	if (str.len > 0) {
+		g_autofree gchar *filename = teco_file_expand_path(str.data);
 
 		teco_qreg_t *glob_reg = teco_qreg_table_find(&teco_qreg_table_globals, "_", 1);
 		g_assert(glob_reg != NULL);
@@ -456,7 +456,7 @@ TECO_DEFINE_STATE_EXPECTGLOB(teco_state_glob_pattern,
 );
 
 static teco_state_t *
-teco_state_glob_filename_done(teco_machine_main_t *ctx, const teco_string_t *str, GError **error)
+teco_state_glob_filename_done(teco_machine_main_t *ctx, teco_string_t str, GError **error)
 {
 	if (ctx->flags.mode > TECO_MODE_NORMAL)
 		return &teco_state_start;
@@ -495,16 +495,16 @@ teco_state_glob_filename_done(teco_machine_main_t *ctx, const teco_string_t *str
 	if (!glob_reg->vtable->get_string(glob_reg, &pattern_str.data, &pattern_str.len,
 	                                  NULL, error))
 		return NULL;
-	if (teco_string_contains(&pattern_str, '\0')) {
+	if (teco_string_contains(pattern_str, '\0')) {
 		teco_error_qregcontainsnull_set(error, "_", 1, FALSE);
 		return NULL;
 	}
 
-	if (str->len > 0) {
+	if (str.len > 0) {
 		/*
 		 * Match pattern against provided file name
 		 */
-		g_autofree gchar *filename = teco_file_expand_path(str->data);
+		g_autofree gchar *filename = teco_file_expand_path(str.data);
 		g_autoptr(GRegex) pattern = teco_globber_compile_pattern(pattern_str.data);
 
 		if (g_regex_match(pattern, filename, 0, NULL) &&