aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/help.cpp
diff options
context:
space:
mode:
authorRobin Haberkorn <robin.haberkorn@googlemail.com>2016-11-20 05:27:10 +0100
committerRobin Haberkorn <robin.haberkorn@googlemail.com>2016-11-20 05:54:44 +0100
commit19675a1a4899f68a4e7afbd45cebc63b544650e4 (patch)
tree22815deaea7a791cd86ea276fe1b20de3c558512 /src/help.cpp
parent255c8085c1132ce79db82fc620a76bab5f8709de (diff)
downloadsciteco-19675a1a4899f68a4e7afbd45cebc63b544650e4.tar.gz
optimized RBTree: avoid unnecessary virtual RBTree and RBEntry implementation classes
* whenever the implementation class was not exactly RBEntryType, it had to have a virtual destructor since RBTree cared about cleanup and had to delete its members. * Since it does not allocate them, it is consistent to remove RBTree::clear(). The destructor now only checks that subclasses have cleaned up. Implementing cleanup in the subclasses is trivial. * Consequently, RBEntryString no longer has to be virtual. HelpIndex and GotoTables are completely non-virtual now which saves memory (and a bit of cleanup speed). For QRegister, not much changes, though.
Diffstat (limited to 'src/help.cpp')
-rw-r--r--src/help.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/help.cpp b/src/help.cpp
index 542a11f..3b82c4c 100644
--- a/src/help.cpp
+++ b/src/help.cpp
@@ -51,7 +51,7 @@ HelpIndex::load(void)
GDir *women_dir;
const gchar *basename;
- if (G_UNLIKELY(min() != NULL))
+ if (G_LIKELY(min() != NULL))
/* already loaded */
return;