optimized RBTree: avoid unnecessary virtual RBTree and RBEntry implementation classes

 * whenever the implementation class was not exactly RBEntryType,
   it had to have a virtual destructor since RBTree cared about
   cleanup and had to delete its members.
 * Since it does not allocate them, it is consistent to remove RBTree::clear().
   The destructor now only checks that subclasses have cleaned up.
   Implementing cleanup in the subclasses is trivial.
 * Consequently, RBEntryString no longer has to be virtual.
   HelpIndex and GotoTables are completely non-virtual now
   which saves memory (and a bit of cleanup speed).
   For QRegister, not much changes, though.

1 files changed, 8 insertions, 0 deletions

diff --git a/src/help.h b/src/help.h
index 92115ab..55fb2ee 100644
--- a/src/help.h
+++ b/src/help.h
@@ -47,6 +47,14 @@ public:
 		}
 	};
 
+	~HelpIndex()
+	{
+		Topic *cur;
+
+		while ((cur = (Topic *)min()))
+			delete (Topic *)remove(cur);
+	}
+
 	void load(void);
 
 	Topic *find(const gchar *name);