instead of relying on Scintilla undo actions, use SciTECO undo tokens exclusivelyHEADmaster-fmsbw-cimaster

Previously we were using both Scintilla undo actions and our own undo tokens
and both had to be coordinated via `undo__teco_interface_ssm(SCI_UNDO, 0, 0)`.
This was error prone since we have to predict when an undo action is actually
generated. Furthermore, you had to update SCI_SETUNDOCOLLECTION on all buffers
and the Q-Reg view whenever switching to and from interactive mode.
Also, this probably wasted memory for the doubled undo bookkeeping.
Now, we always set SCI_SETUNDOCOLLECTION(FALSE), even in interactive mode.
teco_undo_view_insert() was introduced to undo text deletions.
While this saves almost no lines of code, it's just a clearer and simpler
architecture.

1 files changed, 5 insertions, 16 deletions

diff --git a/src/move-commands.c b/src/move-commands.c
index 9ef893e..868bb19 100644
--- a/src/move-commands.c
+++ b/src/move-commands.c
@@ -472,14 +472,10 @@ teco_state_start_delete_words(teco_machine_main_t *ctx, const gchar *cmd, gint f
 		if (start_pos < pos)
 			teco_current_doc_set_dot(teco_interface_bytes2glyphs_absdot(start_pos));
 
-		teco_interface_ssm(SCI_BEGINUNDOACTION, 0, 0);
-		teco_interface_ssm(SCI_DELETERANGE, start_pos, end_pos-start_pos);
-		teco_interface_ssm(SCI_ENDUNDOACTION, 0, 0);
+		if (teco_current_doc_must_undo())
+			teco_undo_interface_insert(start_pos, end_pos-start_pos);
 
-		if (teco_current_doc_must_undo()) {
-			undo__teco_interface_ssm(SCI_GOTOPOS, pos, 0);
-			undo__teco_interface_ssm(SCI_UNDO, 0, 0);
-		}
+		teco_interface_ssm(SCI_DELETERANGE, start_pos, end_pos-start_pos);
 		teco_ring_dirtify();
 	}
 
@@ -562,17 +558,10 @@ teco_state_start_kill(teco_machine_main_t *ctx, const gchar *cmd, gboolean by_li
 	if (len == 0 || teco_is_failure(rc))
 		return TRUE;
 
-	if (teco_current_doc_must_undo()) {
-		undo__teco_interface_ssm(SCI_GOTOPOS, pos, 0);
-		undo__teco_interface_ssm(SCI_UNDO, 0, 0);
-	}
+	if (teco_current_doc_must_undo())
+		teco_undo_interface_insert(from, len);
 
-	/*
-	 * Should always generate an undo action.
-	 */
-	teco_interface_ssm(SCI_BEGINUNDOACTION, 0, 0);
 	teco_interface_ssm(SCI_DELETERANGE, from, len);
-	teco_interface_ssm(SCI_ENDUNDOACTION, 0, 0);
 	teco_ring_dirtify();
 
 	return TRUE;