save some bytes per Q-Register creation on the undo stack

 * a table reference was stored in the UndoToken.
 * since there are only two tables at a given moment, this can
   be avoided by having two different undo tokens, one for globals
   and one for locals.
 * Practically, undo tokens for locals are only created for the
   top-level local Q-Reg table since macro calls with locals
   with set must_undo to false since the local table is destroyed
   with the macro return.

1 files changed, 33 insertions, 0 deletions

diff --git a/src/qregisters.cpp b/src/qregisters.cpp
index 19590c9..7d18910 100644
--- a/src/qregisters.cpp
+++ b/src/qregisters.cpp
@@ -697,6 +697,39 @@ QRegisterClipboard::undo_exchange_string(QRegisterData &reg)
 }
 
 void
+QRegisterTable::UndoTokenRemoveGlobal::run(void)
+{
+	delete (QRegister *)QRegisters::globals.remove(reg);
+}
+
+void
+QRegisterTable::UndoTokenRemoveLocal::run(void)
+{
+	/*
+	 * NOTE: QRegisters::locals should point
+	 * to the correct table when the token is
+	 * executed.
+	 */
+	delete (QRegister *)QRegisters::locals->remove(reg);
+}
+
+void
+QRegisterTable::undo_remove(QRegister *reg)
+{
+	if (!must_undo)
+		return;
+
+	/*
+	 * NOTE: Could also be solved using a virtual
+	 * method and subclasses...
+	 */
+	if (this == &QRegisters::globals)
+		undo.push<UndoTokenRemoveGlobal>(reg);
+	else
+		undo.push<UndoTokenRemoveLocal>(reg);
+}
+
+void
 QRegisterTable::insert_defaults(void)
 {
 	/* general purpose registers */