aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/ring.c
diff options
context:
space:
mode:
authorRobin Haberkorn <rhaberkorn@fmsbw.de>2026-09-25 01:43:56 +0200
committerRobin Haberkorn <rhaberkorn@fmsbw.de>2026-09-25 01:43:56 +0200
commite371b5fc710c597e175e6b7d7645b3a224a731a1 (patch)
tree3861fa4949adfd1c95a06ae0b7dd41c4167a3b7a /src/ring.c
parent207af96f4eb3220534ea06c2e107517372246544 (diff)
instead of relying on Scintilla undo actions, use SciTECO undo tokens exclusivelyHEADmaster-fmsbw-cimaster
Previously we were using both Scintilla undo actions and our own undo tokens and both had to be coordinated via `undo__teco_interface_ssm(SCI_UNDO, 0, 0)`. This was error prone since we have to predict when an undo action is actually generated. Furthermore, you had to update SCI_SETUNDOCOLLECTION on all buffers and the Q-Reg view whenever switching to and from interactive mode. Also, this probably wasted memory for the doubled undo bookkeeping. Now, we always set SCI_SETUNDOCOLLECTION(FALSE), even in interactive mode. teco_undo_view_insert() was introduced to undo text deletions. While this saves almost no lines of code, it's just a clearer and simpler architecture.
Diffstat (limited to 'src/ring.c')
-rw-r--r--src/ring.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/src/ring.c b/src/ring.c
index dc43ac5..d7643d0 100644
--- a/src/ring.c
+++ b/src/ring.c
@@ -503,15 +503,6 @@ teco_ring_undo_close(void)
undo__teco_ring_remove_buffer(teco_ring_current);
}
-void
-teco_ring_set_scintilla_undo(gboolean state)
-{
- for (teco_tailq_entry_t *cur = teco_ring_head.first; cur != NULL; cur = cur->next) {
- teco_buffer_t *buffer = (teco_buffer_t *)cur;
- teco_view_set_scintilla_undo(buffer->view, state);
- }
-}
-
gboolean
teco_ring_sync_lsp(GError **error)
{
@@ -783,7 +774,7 @@ teco_state_read_file_done(teco_machine_main_t *ctx, teco_string_t str, GError **
teco_ring_dirtify();
if (teco_current_doc_must_undo())
- undo__teco_interface_ssm(SCI_UNDO, 0, 0);
+ undo__teco_interface_ssm(SCI_DELETERANGE, from, to-from);
}
return &teco_state_start;