From aa00bf10d986bf3a022c33be1cb79fdd4dadf438 Mon Sep 17 00:00:00 2001
From: Robin Haberkorn <robin.haberkorn@googlemail.com>
Date: Sun, 24 Oct 2021 01:15:59 +0300
Subject: added ./configure --enable-debug and make sure that NDEBUG is defined
 properly

* This simplifies writing CFLAGS="-g -O0" CXXFLAGS="-g -O0".
* We build "release" binaries by default.
  NDEBUG will now be defined unless you specify --enable-debug.
  This enables some optimizations that have long been implemented but were never actually active:
  * SciTECO shuts down faster since it will not explicitly free memory.
    On the downside, this would complicate memory debugging with Valgrind/memcheck.
  * dlmalloc is built with -DINSECURE=1 which is supposedly a bit faster.
    Some compilers also complained about an unportable preprocessor usage which should
    now be gone.
* All CI builds are now with --enable-debug.
  This will slow them down but ensure that more code is executed and thus tested.
---
 .github/workflows/ci.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

(limited to '.github/workflows/ci.yml')

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 336b15e..d0566cc 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -33,7 +33,8 @@ jobs:
     - name: Configure Build
       run: |
         autoreconf -i
-        ./configure --with-interface=${{ matrix.interface }} --enable-html-manual ${{ matrix.compiler }}
+        ./configure --with-interface=${{ matrix.interface }} --enable-debug --enable-html-manual \
+                    ${{ matrix.compiler }}
 
     # NOTE: xvfb-run emulates an XServer and is required when building
     # Gtk versions (since SciTECO calls itself during the build).
@@ -75,7 +76,7 @@ jobs:
         CXX: clang++
       run: |
         autoreconf -i
-        ./configure --with-interface=ncurses --enable-html-manual
+        ./configure --with-interface=ncurses --enable-debug --enable-html-manual
 
     - run: make
     - run: make install
@@ -124,7 +125,7 @@ jobs:
         PDCURSES_CFLAGS: -I/mingw32/include/pdcurses/
       run: |
         autoreconf -i
-        ./configure --with-interface=pdcurses-gui --enable-html-manual
+        ./configure --with-interface=pdcurses-gui --enable-debug --enable-html-manual
 
     - run: make
     - run: make install
-- 
cgit v1.2.3