From 4ca4ba21ccfb6c415462d5a748e7dee5a82121e0 Mon Sep 17 00:00:00 2001 From: Robin Haberkorn Date: Sat, 21 Sep 2024 14:29:11 +0200 Subject: disable shared libraries by default * This is necessary to fix the Unicode test suite on Win32, so I was always passing in --disable-shared manually. It's easy to forget though when building from scratch. * We don't currently install any (shared) library, so this is safe on all platforms. In fact on all other platforms, libtool detects that and doesn't generate wrapper binaries in any way. Only on win32 it's apparently buggy. --- .github/workflows/nightly.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to '.github/workflows/nightly.yml') diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 918e2c4..0af6612 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -212,17 +212,14 @@ jobs: CFLAGS: -O3 -flto CXXFLAGS: -O3 -flto LDFLAGS: -flto - # --disable-shared makes sure that libtool won't create wrapper binaries. - # They are not required and cause problems when running the test suite - # as they don't pass down UTF-8 parameters properly. run: | autoreconf -i mkdir build-wingui build-wincon (cd build-wingui - ../configure --with-interface=pdcurses-gui --disable-shared --enable-html-manual --program-prefix=g \ + ../configure --with-interface=pdcurses-gui --enable-html-manual --program-prefix=g \ PDCURSES_LIBS="-lpdcurses_wingui -lgdi32 -lcomdlg32 -lwinmm") (cd build-wincon - ../configure --with-interface=pdcurses --disable-shared --enable-html-manual \ + ../configure --with-interface=pdcurses --enable-html-manual \ PDCURSES_LIBS="-lpdcurses_wincon -lgdi32 -lwinmm") - name: make @@ -300,12 +297,9 @@ jobs: CFLAGS: -O3 -flto CXXFLAGS: -O3 -flto LDFLAGS: -flto - # --disable-shared makes sure that libtool won't create wrapper binaries. - # They are not required and cause problems when running the test suite - # as they don't pass down UTF-8 parameters properly. run: | autoreconf -i - ./configure --with-interface=gtk --disable-shared --enable-html-manual + ./configure --with-interface=gtk --enable-html-manual - name: make run: make -j 2 -- cgit v1.2.3