From e2c7c11066739cf1141f1d47dc3789a5e82eb9cd Mon Sep 17 00:00:00 2001 From: Robin Haberkorn Date: Thu, 22 Aug 2024 17:35:15 +0200 Subject: some updates on Scintilla/Lexilla out-of-tree builds --- TODO | 4 ++++ contrib/scintilla.am | 3 +++ 2 files changed, 7 insertions(+) diff --git a/TODO b/TODO index ba9ace0..edf63e7 100644 --- a/TODO +++ b/TODO @@ -4,6 +4,9 @@ Tasks: "edit" hook. Known Bugs: + * A local Q-Register can be left as the edited document + even after invoking a macro via . + This is probably not safe and we should throw an error instead. * E%$...$ broken. Similarily EQ$file$ won't do what you would expect it to. * <23(1;)> leaves values on the stack and the internal hidden @@ -101,6 +104,7 @@ Known Bugs: logging system. * Out-of-tree builds are broken. See contrib/scintilla.am. + See also https://github.com/ScintillaOrg/lexilla/issues/266 * Gtk on Unix: On ^Z, we do not suspend properly. The window is still shown. This would be a useful feature especially with --xembed on st. Perhaps we should try to catch SIGTSTP? diff --git a/contrib/scintilla.am b/contrib/scintilla.am index 6c75e65..55511b0 100644 --- a/contrib/scintilla.am +++ b/contrib/scintilla.am @@ -5,6 +5,8 @@ # 1.) Out-of-tree builds are not straight forward and require # manually cloning the submodules into the build system. # `make distcheck` is consequently also broken. +# Lexilla already has DIR_O, that could be used for proper +# out of tree builds, but Scintilla is still lacking it. # 2.) We cannot add plain static libraries to libtool convenience # libraries using LIBADD. # Therefore, we cannot wrap Scintilla and Lexilla into a convenience @@ -53,6 +55,7 @@ clean-local-scintilla: $(MAKE_SCINTILLA) clean MAKE_LEXILLA = $(MAKE) -C @LEXILLA_PATH@/src \ + SCINTILLA_INCLUDE=@SCINTILLA_PATH@/include \ CXXFLAGS='@SCINTILLA_CXXFLAGS@' \ CC='@CC@' CXX='@CXX@' \ AR='@AR@' RANLIB='@RANLIB@' -- cgit v1.2.3