From 605bd59516b0868cc73ed01f913eeb331033a84b Mon Sep 17 00:00:00 2001 From: Robin Haberkorn Date: Sun, 10 Nov 2024 23:16:52 +0300 Subject: Win32: fixed Unicode commandlines with newer MinGW runtimes * should also fix Win32 nightly builds * Even though we weren't using main's argv, but were using glib API for retrieving the command line in UTF-8, newer MinGW runtimes would fail when converting the Unicode command line into the system codepage would be lossy. * Most people seem to compile in a "manifest" to work around this issue. But this requires newer Windows versions and using some Microsoft tool which isn't even in $PATH. Instead, we now link with -municode and define wmain() instead, even though we still ignore argv. wmain() proabably get's the command line in UTF-16 and we'd have to convert it anyway. * See https://github.com/msys2/MINGW-packages/issues/22462 --- TODO | 4 ---- 1 file changed, 4 deletions(-) (limited to 'TODO') diff --git a/TODO b/TODO index e5d2bf4..c0ff79a 100644 --- a/TODO +++ b/TODO @@ -149,10 +149,6 @@ Known Bugs: Automatically running EF EB...$ in the "save" hook could also have unwanted side effects. * session.vcs does not properly work in MSYS2 environments. - * Win32: Unicode CI tests sometimes spuriously fail due to - "Command line contains characters that are not supported - in the active code page (1252)." - Apparently I am not the only user with this bug. Features: * Auto-indention could be implemented via context-sensitive -- cgit v1.2.3