From 257a0bf128e109442dce91c4aaa1d97fed17ad1a Mon Sep 17 00:00:00 2001 From: Robin Haberkorn Date: Wed, 19 Mar 2025 12:32:10 +0300 Subject: fixed leaking data on rubout * Objects, that are restored with TECO_DEFINE_UNDO_OBJECT_OWN(), could actually leak memory on rubout since the old object was not deleted when overwriting it. * Now that it is, it is crucial to at least nullify objects/pointers after calling the corresponding push-function. These conditions are now explicitly documented. * The test suite now runs successfully under Valgrind even with full leak checking. --- src/goto-commands.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/goto-commands.c') diff --git a/src/goto-commands.c b/src/goto-commands.c index d463151..bf5743e 100644 --- a/src/goto-commands.c +++ b/src/goto-commands.c @@ -90,6 +90,8 @@ teco_state_label_input(teco_machine_main_t *ctx, gunichar chr, GError **error) teco_undo_string_own(ctx->goto_label); else teco_string_clear(&ctx->goto_label); + memset(&ctx->goto_label, 0, sizeof(ctx->goto_label)); + return &teco_state_start; } -- cgit v1.2.3