From 7206f6d1249da0dd8e879d0c0b26185fc6ef89d9 Mon Sep 17 00:00:00 2001 From: Robin Haberkorn Date: Tue, 11 Nov 2014 04:14:01 +0100 Subject: added all of SciTECO's declarations to the "SciTECO" namespace normally, since SciTECO is not a library, this is not strictly necessary since every library should use proper name prefixes or namespaces for all global declarations to avoid name clashes. However * you cannot always rely on that * Scintilla does violate the practice of using prefixes or namespaces. The public APIs are OK, but it does define global functions/methods, e.g. for "Document" that clashed with SciTECO's "TECODocument" class at link-time. Scintilla can put its definitions in a namespace, but this feature cannot be easily enabled without patching Scintilla. * a "SciTECO" namespace will be necessary if "SciTECO" is ever to be turned into a library. Even if this library will have only a C-linkage API, it must ensure it doesn't clutter the global namespace. So the old "TECODocument" class was renamed back to "Document" (SciTECO::Document). --- src/qregisters.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/qregisters.cpp') diff --git a/src/qregisters.cpp b/src/qregisters.cpp index 673c831..aba5abf 100644 --- a/src/qregisters.cpp +++ b/src/qregisters.cpp @@ -37,6 +37,8 @@ #include "ring.h" #include "qregisters.h" +namespace SciTECO { + namespace States { StatePushQReg pushqreg; StatePopQReg popqreg; @@ -851,3 +853,5 @@ StateCopyToQReg::got_register(QRegister ®) return &States::start; } + +} /* namespace SciTECO */ -- cgit v1.2.3