aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorNeil <nyamatongwe@gmail.com>2020-02-29 09:11:59 +1100
committerNeil <nyamatongwe@gmail.com>2020-02-29 09:11:59 +1100
commit190e7c5a66f6e3bfa633d0a4705f96312d385013 (patch)
treee18d80e5327e8dd50c0e942fab9abca4e378b907
parent69f9cd35dfa530c657c1853a471a4bc45db1818f (diff)
downloadscintilla-mirror-190e7c5a66f6e3bfa633d0a4705f96312d385013.tar.gz
Backport: Add const and noexcept where they make sense.
Backport of changeset 7991:d7d83db0457a.
-rw-r--r--src/Editor.cxx8
-rw-r--r--src/Editor.h8
2 files changed, 8 insertions, 8 deletions
diff --git a/src/Editor.cxx b/src/Editor.cxx
index 5bbc55969..fb3aae6a1 100644
--- a/src/Editor.cxx
+++ b/src/Editor.cxx
@@ -561,7 +561,7 @@ Sci::Position Editor::CurrentPosition() const {
return sel.MainCaret();
}
-bool Editor::SelectionEmpty() const {
+bool Editor::SelectionEmpty() const noexcept {
return sel.Empty();
}
@@ -785,7 +785,7 @@ void Editor::MultipleSelectAdd(AddNumber addNumber) {
}
}
-bool Editor::RangeContainsProtected(Sci::Position start, Sci::Position end) const {
+bool Editor::RangeContainsProtected(Sci::Position start, Sci::Position end) const noexcept {
if (vs.ProtectionActive()) {
if (start > end) {
const Sci::Position t = start;
@@ -800,7 +800,7 @@ bool Editor::RangeContainsProtected(Sci::Position start, Sci::Position end) cons
return false;
}
-bool Editor::SelectionContainsProtected() {
+bool Editor::SelectionContainsProtected() const {
for (size_t r=0; r<sel.Count(); r++) {
if (RangeContainsProtected(sel.Range(r).Start().Position(),
sel.Range(r).End().Position())) {
@@ -1920,7 +1920,7 @@ void Editor::InsertCharacter(const char *s, unsigned int len, CharacterSource ch
}
// Order selections by position in document.
std::sort(selPtrs.begin(), selPtrs.end(),
- [](const SelectionRange *a, const SelectionRange *b) {return *a < *b;});
+ [](const SelectionRange *a, const SelectionRange *b) noexcept {return *a < *b;});
// Loop in reverse to avoid disturbing positions of selections yet to be processed.
for (std::vector<SelectionRange *>::reverse_iterator rit = selPtrs.rbegin();
diff --git a/src/Editor.h b/src/Editor.h
index c88a181a7..c21043881 100644
--- a/src/Editor.h
+++ b/src/Editor.h
@@ -312,7 +312,7 @@ protected: // ScintillaBase subclass needs access to much of Editor
return ((virtualSpaceOptions & SCVS_USERACCESSIBLE) != 0);
}
Sci::Position CurrentPosition() const;
- bool SelectionEmpty() const;
+ bool SelectionEmpty() const noexcept;
SelectionPosition SelectionStart();
SelectionPosition SelectionEnd();
void SetRectangularRange();
@@ -328,8 +328,8 @@ protected: // ScintillaBase subclass needs access to much of Editor
void SetEmptySelection(Sci::Position currentPos_);
enum AddNumber { addOne, addEach };
void MultipleSelectAdd(AddNumber addNumber);
- bool RangeContainsProtected(Sci::Position start, Sci::Position end) const;
- bool SelectionContainsProtected();
+ bool RangeContainsProtected(Sci::Position start, Sci::Position end) const noexcept;
+ bool SelectionContainsProtected() const;
Sci::Position MovePositionOutsideChar(Sci::Position pos, Sci::Position moveDir, bool checkLineEnd=true) const;
SelectionPosition MovePositionOutsideChar(SelectionPosition pos, Sci::Position moveDir, bool checkLineEnd=true) const;
void MovedCaret(SelectionPosition newPos, SelectionPosition previousPos,
@@ -640,7 +640,7 @@ class AutoSurface {
private:
std::unique_ptr<Surface> surf;
public:
- AutoSurface(Editor *ed, int technology = -1) {
+ AutoSurface(const Editor *ed, int technology = -1) {
if (ed->wMain.GetID()) {
surf.reset(Surface::Allocate(technology != -1 ? technology : ed->technology));
surf->Init(ed->wMain.GetID());