aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorNeil <nyamatongwe@gmail.com>2013-12-22 17:57:01 +1100
committerNeil <nyamatongwe@gmail.com>2013-12-22 17:57:01 +1100
commit2787782594e67e452488cea730e052538cb9a3f1 (patch)
treebfe8d6a69a9e83062ea0b58377a4c25799866730
parent2bf62e817722b4951830fbaa6c66ba88e40e565d (diff)
downloadscintilla-mirror-2787782594e67e452488cea730e052538cb9a3f1.tar.gz
Switch from char[] to std::string for simplicity and safety.
-rw-r--r--src/AutoComplete.cxx14
-rw-r--r--src/AutoComplete.h4
2 files changed, 7 insertions, 11 deletions
diff --git a/src/AutoComplete.cxx b/src/AutoComplete.cxx
index c33d0c3a8..d154a913a 100644
--- a/src/AutoComplete.cxx
+++ b/src/AutoComplete.cxx
@@ -16,9 +16,9 @@
#include "Platform.h"
+#include "Scintilla.h"
#include "CharacterSet.h"
#include "AutoComplete.h"
-#include "Scintilla.h"
#ifdef SCI_NAMESPACE
using namespace Scintilla;
@@ -41,8 +41,6 @@ AutoComplete::AutoComplete() :
heightLBDefault(100),
autoSort(SC_ORDER_PRESORTED) {
lb = ListBox::Allocate();
- stopChars[0] = '\0';
- fillUpChars[0] = '\0';
}
AutoComplete::~AutoComplete() {
@@ -71,21 +69,19 @@ void AutoComplete::Start(Window &parent, int ctrlID,
}
void AutoComplete::SetStopChars(const char *stopChars_) {
- strncpy(stopChars, stopChars_, sizeof(stopChars));
- stopChars[sizeof(stopChars) - 1] = '\0';
+ stopChars = stopChars_;
}
bool AutoComplete::IsStopChar(char ch) {
- return ch && strchr(stopChars, ch);
+ return ch && (stopChars.find(ch) != std::string::npos);
}
void AutoComplete::SetFillUpChars(const char *fillUpChars_) {
- strncpy(fillUpChars, fillUpChars_, sizeof(fillUpChars));
- fillUpChars[sizeof(fillUpChars) - 1] = '\0';
+ fillUpChars = fillUpChars_;
}
bool AutoComplete::IsFillUpChar(char ch) {
- return ch && strchr(fillUpChars, ch);
+ return ch && (fillUpChars.find(ch) != std::string::npos);
}
void AutoComplete::SetSeparator(char separator_) {
diff --git a/src/AutoComplete.h b/src/AutoComplete.h
index f7a0c3f1e..6838e4306 100644
--- a/src/AutoComplete.h
+++ b/src/AutoComplete.h
@@ -16,8 +16,8 @@ namespace Scintilla {
*/
class AutoComplete {
bool active;
- char stopChars[256];
- char fillUpChars[256];
+ std::string stopChars;
+ std::string fillUpChars;
char separator;
char typesep; // Type seperator
enum { maxItemLen=1000 };