aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorNeil <nyamatongwe@gmail.com>2022-07-22 20:36:39 +1000
committerNeil <nyamatongwe@gmail.com>2022-07-22 20:36:39 +1000
commit4bfb45aca9a2e2dd181cdd6f5d7823ac3ae72a0e (patch)
treebb58c0eaae6ea9f3764fa13dd49c7cbcd47b8a1b
parent6d53881b6c21e7824ba3c83ac175bb233f8ff2a8 (diff)
downloadscintilla-mirror-4bfb45aca9a2e2dd181cdd6f5d7823ac3ae72a0e.tar.gz
Bug [#2335] Fix incorrect display of selection when printing in some modes.
-rw-r--r--doc/ScintillaHistory.html4
-rw-r--r--src/EditView.cxx7
2 files changed, 5 insertions, 6 deletions
diff --git a/doc/ScintillaHistory.html b/doc/ScintillaHistory.html
index 81f76dc48..fb3a45cc8 100644
--- a/doc/ScintillaHistory.html
+++ b/doc/ScintillaHistory.html
@@ -592,6 +592,10 @@
This requires gcc 11.3 or clang 14.
<a href="https://sourceforge.net/p/scintilla/bugs/2338/">Bug #2338</a>.
</li>
+ <li>
+ Fix incorrect display of selection when printing in some modes.
+ <a href="https://sourceforge.net/p/scintilla/bugs/2335/">Bug #2335</a>.
+ </li>
</ul>
<h3>
<a href="https://www.scintilla.org/scintilla524.zip">Release 5.2.4</a>
diff --git a/src/EditView.cxx b/src/EditView.cxx
index 554582bcb..986772fe2 100644
--- a/src/EditView.cxx
+++ b/src/EditView.cxx
@@ -2695,14 +2695,9 @@ Sci::Position EditView::FormatRange(bool draw, CharacterRangeFull chrg, Rectangl
// If this ever gets changed, cached pixmap would need to be recreated if technology != Technology::Default
vsPrint.viewIndentationGuides = IndentView::None;
// Don't show the selection when printing
+ vsPrint.selection.visible = false;
vsPrint.elementColours.clear();
vsPrint.elementBaseColours.clear();
- // Set all selection background colours to be transparent.
- constexpr ColourRGBA transparent(0xc0, 0xc0, 0xc0, 0x0);
- vsPrint.elementBaseColours[Element::SelectionBack] = transparent;
- vsPrint.elementBaseColours[Element::SelectionAdditionalBack] = transparent;
- vsPrint.elementBaseColours[Element::SelectionSecondaryBack] = transparent;
- vsPrint.elementBaseColours[Element::SelectionInactiveBack] = transparent;
vsPrint.caretLine.alwaysShow = false;
// Don't highlight matching braces using indicators
vsPrint.braceHighlightIndicatorSet = false;