aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorNeil <nyamatongwe@gmail.com>2019-03-19 09:04:39 +1100
committerNeil <nyamatongwe@gmail.com>2019-03-19 09:04:39 +1100
commit5c9c8f89c962785bcaac84e9a9c22d7976a03784 (patch)
tree548dc70bf319b7784845b7f3f6f2de63a402fc4e
parent7e4bd49b1315de495ad37ed7d19897abdcf44b94 (diff)
downloadscintilla-mirror-5c9c8f89c962785bcaac84e9a9c22d7976a03784.tar.gz
Backport: Make destructors public to avoid warnings.
Backport of changeset 7323:09b4042d7092.
-rw-r--r--src/Editor.h4
-rw-r--r--src/ScintillaBase.h4
-rw-r--r--win32/ScintillaWin.cxx4
3 files changed, 9 insertions, 3 deletions
diff --git a/src/Editor.h b/src/Editor.h
index cbdd171cf..e8d1ed48e 100644
--- a/src/Editor.h
+++ b/src/Editor.h
@@ -260,7 +260,7 @@ protected: // ScintillaBase subclass needs access to much of Editor
Editor(Editor &&) = delete;
Editor &operator=(const Editor &) = delete;
Editor &operator=(Editor &&) = delete;
- ~Editor() override;
+ // ~Editor() in public section
virtual void Initialise() = 0;
virtual void Finalise();
@@ -599,6 +599,8 @@ protected: // ScintillaBase subclass needs access to much of Editor
static sptr_t BytesResult(sptr_t lParam, const unsigned char *val, size_t len) noexcept;
public:
+ ~Editor() override;
+
// Public so the COM thunks can access it.
bool IsUnicodeMode() const noexcept;
// Public so scintilla_send_message can use it.
diff --git a/src/ScintillaBase.h b/src/ScintillaBase.h
index e886f22e2..39fb9d411 100644
--- a/src/ScintillaBase.h
+++ b/src/ScintillaBase.h
@@ -57,7 +57,7 @@ protected:
ScintillaBase(ScintillaBase &&) = delete;
ScintillaBase &operator=(const ScintillaBase &) = delete;
ScintillaBase &operator=(ScintillaBase &&) = delete;
- ~ScintillaBase() override;
+ // ~ScintillaBase() in public section
void Initialise() override {}
void Finalise() override;
@@ -94,6 +94,8 @@ protected:
void NotifyLexerChanged(Document *doc, void *userData) override;
public:
+ ~ScintillaBase() override;
+
// Public so scintilla_send_message can use it
sptr_t WndProc(unsigned int iMessage, uptr_t wParam, sptr_t lParam) override;
};
diff --git a/win32/ScintillaWin.cxx b/win32/ScintillaWin.cxx
index b1f0412bd..6561da916 100644
--- a/win32/ScintillaWin.cxx
+++ b/win32/ScintillaWin.cxx
@@ -303,7 +303,7 @@ class ScintillaWin :
ScintillaWin(ScintillaWin &&) = delete;
ScintillaWin &operator=(const ScintillaWin &) = delete;
ScintillaWin &operator=(ScintillaWin &&) = delete;
- ~ScintillaWin() override;
+ // ~ScintillaWin() in public section
void Init();
void Finalise() override;
@@ -399,6 +399,8 @@ class ScintillaWin :
sptr_t GetText(uptr_t wParam, sptr_t lParam);
public:
+ ~ScintillaWin() override;
+
// Public for benefit of Scintilla_DirectFunction
sptr_t WndProc(unsigned int iMessage, uptr_t wParam, sptr_t lParam) override;