Avoiding warnings from cppcheck. Mostly removing bodies of private copy

constructors and operator=.
Also ensuring initialisation for some fields, reducing scope where
possible, and passing by const reference.

1 files changed, 3 insertions, 4 deletions

diff --git a/src/ScintillaBase.h b/src/ScintillaBase.h
index 73fcd72b5..f1fdc5dfd 100644
--- a/src/ScintillaBase.h
+++ b/src/ScintillaBase.h
@@ -16,8 +16,8 @@ namespace Scintilla {
  */
 class ScintillaBase : public Editor {
 	// Private so ScintillaBase objects can not be copied
-	ScintillaBase(const ScintillaBase &) : Editor() {}
-	ScintillaBase &operator=(const ScintillaBase &) { return *this; }
+	ScintillaBase(const ScintillaBase &);
+	ScintillaBase &operator=(const ScintillaBase &);
 
 protected:
 	/** Enumeration of commands and child windows. */
@@ -43,9 +43,8 @@ protected:
 	int listType;			///< 0 is an autocomplete list
 	int maxListWidth;		/// Maximum width of list, in average character widths
 
-	bool performingStyle;	///< Prevent reentrance
-
 #ifdef SCI_LEXER
+	bool performingStyle;	///< Prevent reentrance
 	int lexLanguage;
 	const LexerModule *lexCurrent;
 	PropSetSimple props;