diff options
author | Neil <nyamatongwe@gmail.com> | 2020-03-23 09:39:32 +1100 |
---|---|---|
committer | Neil <nyamatongwe@gmail.com> | 2020-03-23 09:39:32 +1100 |
commit | 2c591c0f98f84626611ce25eb3686da45465af46 (patch) | |
tree | ceb8b77ddbe2c4a0794744bae39d461cb8e15f69 /src | |
parent | 6d46095c897fa597b963b83dbb66ef4eab42badb (diff) | |
download | scintilla-mirror-2c591c0f98f84626611ce25eb3686da45465af46.tar.gz |
perLineData is polymorphic so replace static_cast with dynamic_cast for better
type safety and adherence to C++ Core Guidelines C.146.
Diffstat (limited to 'src')
-rw-r--r-- | src/Document.cxx | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/Document.cxx b/src/Document.cxx index 16a56cd52..b51d30c0c 100644 --- a/src/Document.cxx +++ b/src/Document.cxx @@ -186,23 +186,23 @@ void Document::RemoveLine(Sci::Line line) { } LineMarkers *Document::Markers() const noexcept { - return static_cast<LineMarkers *>(perLineData[ldMarkers].get()); + return dynamic_cast<LineMarkers *>(perLineData[ldMarkers].get()); } LineLevels *Document::Levels() const noexcept { - return static_cast<LineLevels *>(perLineData[ldLevels].get()); + return dynamic_cast<LineLevels *>(perLineData[ldLevels].get()); } LineState *Document::States() const noexcept { - return static_cast<LineState *>(perLineData[ldState].get()); + return dynamic_cast<LineState *>(perLineData[ldState].get()); } LineAnnotation *Document::Margins() const noexcept { - return static_cast<LineAnnotation *>(perLineData[ldMargin].get()); + return dynamic_cast<LineAnnotation *>(perLineData[ldMargin].get()); } LineAnnotation *Document::Annotations() const noexcept { - return static_cast<LineAnnotation *>(perLineData[ldAnnotation].get()); + return dynamic_cast<LineAnnotation *>(perLineData[ldAnnotation].get()); } int Document::LineEndTypesSupported() const { |