diff options
| author | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2014-11-11 04:14:01 +0100 |
|---|---|---|
| committer | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2014-11-11 04:14:01 +0100 |
| commit | 7206f6d1249da0dd8e879d0c0b26185fc6ef89d9 (patch) | |
| tree | 9f570b266ee49c06290c048b600346ab8b0dbddd /src/expressions.h | |
| parent | 0987ca8b5b1a6ff50bfc8c3b171fdaf6cfff3a2b (diff) | |
| download | sciteco-7206f6d1249da0dd8e879d0c0b26185fc6ef89d9.tar.gz | |
added all of SciTECO's declarations to the "SciTECO" namespace
normally, since SciTECO is not a library, this is not strictly
necessary since every library should use proper name prefixes
or namespaces for all global declarations to avoid name clashes.
However
* you cannot always rely on that
* Scintilla does violate the practice of using prefixes or namespaces.
The public APIs are OK, but it does define global functions/methods,
e.g. for "Document" that clashed with SciTECO's "TECODocument" class at
link-time.
Scintilla can put its definitions in a namespace, but this feature
cannot be easily enabled without patching Scintilla.
* a "SciTECO" namespace will be necessary if "SciTECO" is ever to be
turned into a library. Even if this library will have only a C-linkage
API, it must ensure it doesn't clutter the global namespace.
So the old "TECODocument" class was renamed back to "Document"
(SciTECO::Document).
Diffstat (limited to 'src/expressions.h')
| -rw-r--r-- | src/expressions.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/expressions.h b/src/expressions.h index ef91333..1e61ab8 100644 --- a/src/expressions.h +++ b/src/expressions.h @@ -23,6 +23,8 @@ #include "undo.h" #include "parser.h" // State::Error +namespace SciTECO { + template <typename Type> class ValueStack { class UndoTokenPush : public UndoToken { @@ -214,4 +216,6 @@ private: int first_op(void); } expressions; +} /* namespace SciTECO */ + #endif |