teco_string_t is now passed by value like a scalar if the callee isn't expected to modify it

* When passing a struct that should not be modified, I usually use a const pointer.
* Strings however are small 2-word objects and they are often now already passed via separate
  `gchar*` and gsize parameters. So it is consistent to pass teco_string_t by value as well.
  A teco_string_t will usually fit into registers just like a pointer.
* It's now obvious which function just _uses_ and which function _modifies_ a string.
  There is also no chance to pass a NULL pointer to those functions.

1 files changed, 7 insertions, 4 deletions

diff --git a/src/interface-curses/interface.c b/src/interface-curses/interface.c
index 93a5bd5..5110bc8 100644
--- a/src/interface-curses/interface.c
+++ b/src/interface-curses/interface.c
@@ -236,6 +236,9 @@ static struct {
  * Instead we allocate color pairs beginnig at 128 on demand
  * (similar to what Scinterm does).
  *
+ * @note Scinterm now also has scintilla_set_color_offsets(),
+ * so we could use the lower 127 color pairs as well.
+ *
  * @param fg curses foreground color
  * @param bg curses background color
  * @return curses color pair number
@@ -1169,7 +1172,7 @@ teco_interface_draw_info(void)
 
 	case TECO_INFO_TYPE_BUFFER:
 		info_type_str = PACKAGE_NAME " - <Buffer> ";
-		g_assert(!teco_string_contains(&info_current, '\0'));
+		g_assert(!teco_string_contains(info_current, '\0'));
 		/* "(Unnamed)" buffer has to be looked up as "" */
 		teco_curses_add_wc(teco_interface.info_window,
 		                   teco_ed & TECO_ED_ICONS ? teco_curses_icons_lookup_file(teco_interface.info_current.data) : '-');
@@ -1540,7 +1543,7 @@ teco_interface_set_clipboard(const gchar *name, const gchar *str, gsize str_len,
 	g_auto(teco_string_t) command;
 	if (!reg->vtable->get_string(reg, &command.data, &command.len, NULL, error))
 		return FALSE;
-	if (teco_string_contains(&command, '\0')) {
+	if (teco_string_contains(command, '\0')) {
 		teco_error_qregcontainsnull_set(error, reg_name, strlen(reg_name), FALSE);
 		return FALSE;
 	}
@@ -1601,7 +1604,7 @@ teco_interface_get_clipboard(const gchar *name, gchar **str, gsize *len, GError
 	g_auto(teco_string_t) command;
 	if (!reg->vtable->get_string(reg, &command.data, &command.len, NULL, error))
 		return FALSE;
-	if (teco_string_contains(&command, '\0')) {
+	if (teco_string_contains(command, '\0')) {
 		teco_error_qregcontainsnull_set(error, reg_name, strlen(reg_name), FALSE);
 		return FALSE;
 	}
@@ -1864,7 +1867,7 @@ teco_interface_process_mevent(MEVENT *event, GError **error)
 				 */
 				const teco_string_t insert_suffix = {insert->data + teco_interface.popup_prefix_len,
 				                                     insert->len - teco_interface.popup_prefix_len};
-				if (!machine->current->insert_completion_cb(machine, &insert_suffix, error))
+				if (!machine->current->insert_completion_cb(machine, insert_suffix, error))
 					return FALSE;
 
 				teco_interface_popup_clear();