scroll caret __almost__ always automatically after key presses

* The old heuristics - scroll if dot changes after key press -
  turned out to be too simplistic.
  They broke the clang-format macro (M#cf), which left the view at the
  top of the document since the entire document is temporarily erased.
  Other simplified examples of this bug would be:
  @^Um{[: HECcat$ ]:} Mm
  Or even: @^Um{[: H@X.aG.a ]:} Mm
* Actually, the heuristics could be tricked even without deleting any
  significant amount of text from the buffer.
  The following test case replaces the previous character with a linefeed
  in a single key press:
  @^Um{-DI^J$} Mm
  If executed on the last visible line, dot wouldn't be scrolled into the view
  since it did not change.
* At the same time, we'd like to keep the existing mouse scroll behavior from
  fnkeys.tes, which is allowed to scroll dot outside of the visible area.
  Therefore, dot is scrolled into view always, except after mouse events.
  You may have to call SCI_SCROLLCARET manually in the ^KMOUSE macro,
  which is arguably not always straight forward.
* Some macros like M#cf may still leave the vertical scrolling position
  in unexpected positions. This could either be fixed by eradicating all
  remaining automatic scrolling from Scintilla or by explicitly restoring
  the vertical position from the macro (FIXME).
* This was broken since the introduction of mouse support,
  so it wasn't in v2.3.0.

1 files changed, 6 insertions, 5 deletions

diff --git a/src/interface-curses/interface.c b/src/interface-curses/interface.c
index 75ba036..031ba61 100644
--- a/src/interface-curses/interface.c
+++ b/src/interface-curses/interface.c
@@ -1968,9 +1968,6 @@ teco_interface_event_loop_iter(void)
 			? teco_interface_blocking_getch()
 			: GPOINTER_TO_INT(g_queue_pop_head(teco_interface.input_queue));
 
-	const teco_view_t *last_view = teco_interface_current_view;
-	sptr_t last_pos = teco_interface_ssm(SCI_GETCURRENTPOS, 0, 0);
-
 	switch (key) {
 	case ERR:
 		/* shouldn't really happen */
@@ -2093,9 +2090,13 @@ teco_interface_event_loop_iter(void)
 	 * Scintilla has been patched to avoid any automatic scrolling since that
 	 * has been benchmarked to be a very costly operation.
 	 * Instead we do it only once after every keypress.
+	 *
+	 * The only exception is mouse events, so you can scroll the view manually
+	 * in the ^KMOUSE macro, allowing dot to be outside of the view.
 	 */
-	if (teco_interface_current_view != last_view ||
-	    last_pos != teco_interface_ssm(SCI_GETCURRENTPOS, 0, 0))
+#if NCURSES_MOUSE_VERSION >= 2
+	if (key != KEY_MOUSE)
+#endif
 		teco_interface_ssm(SCI_SCROLLCARET, 0, 0);
 	teco_interface_refresh();
 }