avoid unnecessary undo token allocations in batch mode: greatly speeds up batch mode

 * by using variadic templates, UndoStack::push() is now responsible
   for allocating undo tokens. This is avoided in batch mode.
 * The old UndoStack::push(UndoToken *) method has been made private
   to avoid confusion around UndoStack's API.
   The old UndoStack::push() no longer needs to handle !undo.enabled,
   but at least asserts on it.
 * C++11 support is now required, so variadic templates can be used.
   This could have also been done using manual undo.enabled checks;
   or using multiple versions of the template with different numbers
   of template arguments.
   The latter could be done if we one day have to support a non-C++11
   compiler.
   However since we're depending on GCC 4.4, variadic template use should
   be OK.
   Clang supports it since v2.9.
 * Sometimes, undo token pushing passed ownership of some memory
   to the undo token. The old behaviour was relied on to reclaim the
   memory even in batch mode -- the undo token was always deleted.
   To avoid leaks or repeated manual undo.enabled checking,
   another method UndoStack::push_own() had to be
   introduced that makes sure that an undo token is always created.
   In batch mode (!undo.enabled), this will however create the object
   on the stack which is much cheaper than using `new`.
 * Having to know which kind of undo token is to be pushed (taking ownership
   or not) is inconvenient. It may be better to add static methods to
   the UndoToken classes that can take care of reclaiming memory.
 * Benchmarking certain SciTECO scripts have shown 50% (!!!) speed increases
   at the highest possible optimization level (-O3 -mtune=native -march=native).

1 files changed, 5 insertions, 5 deletions

diff --git a/src/interface.h b/src/interface.h
index 9552984..84182ea 100644
--- a/src/interface.h
+++ b/src/interface.h
@@ -122,14 +122,14 @@ public:
 	undo_ssm(unsigned int iMessage,
 		 uptr_t wParam = 0, sptr_t lParam = 0)
 	{
-		undo.push(new UndoTokenMessage(impl(), iMessage, wParam, lParam));
+		undo.push<UndoTokenMessage>(impl(), iMessage, wParam, lParam);
 	}
 
 	void set_representations(void);
 	inline void
 	undo_set_representations(void)
 	{
-		undo.push(new UndoTokenSetRepresentations(impl()));
+		undo.push<UndoTokenSetRepresentations>(impl());
 	}
 
 	inline void
@@ -233,7 +233,7 @@ public:
 	inline void
 	undo_show_view(ViewImpl *view)
 	{
-		undo.push(new UndoTokenShowView(view));
+		undo.push<UndoTokenShowView>(view);
 	}
 
 	inline ViewImpl *
@@ -273,12 +273,12 @@ public:
 	inline void
 	undo_info_update(const QRegister *reg)
 	{
-		undo.push(new UndoTokenInfoUpdate<QRegister>(reg));
+		undo.push<UndoTokenInfoUpdate<QRegister>>(reg);
 	}
 	inline void
 	undo_info_update(const Buffer *buffer)
 	{
-		undo.push(new UndoTokenInfoUpdate<Buffer>(buffer));
+		undo.push<UndoTokenInfoUpdate<Buffer>>(buffer);
 	}
 
 	inline void