diff options
| author | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2025-07-18 00:34:56 +0300 |
|---|---|---|
| committer | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2025-07-18 00:34:56 +0300 |
| commit | 3a2583e918bcc805fe860252f8a520fc2f9b26ce (patch) | |
| tree | cfe2b7846df4e8c2d1572c6b7b961225a8e87487 /src/qreg-commands.c | |
| parent | 4794367ce0c31f820bf2bd72d44c886984e3f7ed (diff) | |
| download | sciteco-3a2583e918bcc805fe860252f8a520fc2f9b26ce.tar.gz | |
fixed minor memory leaks of per-state data in teco_machine_main_t
* These were leaked e.g. in case of end-of-macro errors,
but also in case of syntax highlighting (teco_lexer_style()).
I considered to solve this by overwriting more of the end_of_macro_cb,
but it didn't turn out to be trivial always.
* Considering that the union in teco_machine_main_t saved only 3 machine words
of memory, I decided to sacrifice those for more robust memory management.
* teco_machine_qregspec_t cannot be directly embedded into teco_machine_main_t
due to recursive dependencies with teco_machine_stringbuilding_t.
It could now and should perhaps be allocated only once in teco_machine_main_init(),
but it would require more refactoring.
Diffstat (limited to 'src/qreg-commands.c')
| -rw-r--r-- | src/qreg-commands.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/qreg-commands.c b/src/qreg-commands.c index 7189771..9407e6c 100644 --- a/src/qreg-commands.c +++ b/src/qreg-commands.c @@ -39,8 +39,8 @@ teco_state_expectqreg_initial(teco_machine_main_t *ctx, GError **error) teco_state_t *current = ctx->parent.current; /* - * NOTE: We have to allocate a new instance always since `expectqreg` - * is part of an union. + * NOTE: This could theoretically be allocated once in + * teco_machine_main_init(), but we'd have to set the type here anyway. */ ctx->expectqreg = teco_machine_qregspec_new(current->expectqreg.type, ctx->qreg_table_locals, ctx->parent.must_undo); @@ -69,7 +69,7 @@ teco_state_expectqreg_input(teco_machine_main_t *ctx, gunichar chr, GError **err /* * NOTE: ctx->expectqreg is preserved since we may want to query it from follow-up - * states. This means, it must usually be stored manually in got_register_cb() via: + * states. This means, it must usually be reset manually in got_register_cb() via: * teco_state_expectqreg_reset(ctx); */ return current->expectqreg.got_register_cb(ctx, qreg, table, error); |