teco_string_t is now passed by value like a scalar if the callee isn't expected to modify it

* When passing a struct that should not be modified, I usually use a const pointer.
* Strings however are small 2-word objects and they are often now already passed via separate
  `gchar*` and gsize parameters. So it is consistent to pass teco_string_t by value as well.
  A teco_string_t will usually fit into registers just like a pointer.
* It's now obvious which function just _uses_ and which function _modifies_ a string.
  There is also no chance to pass a NULL pointer to those functions.

1 files changed, 8 insertions, 8 deletions

diff --git a/src/qreg.c b/src/qreg.c
index 0ca463a..d7652fe 100644
--- a/src/qreg.c
+++ b/src/qreg.c
@@ -732,7 +732,7 @@ teco_qreg_workingdir_set_string(teco_qreg_t *qreg, const gchar *str, gsize len,
 	g_auto(teco_string_t) dir;
 	teco_string_init(&dir, str, len);
 
-	if (teco_string_contains(&dir, '\0')) {
+	if (teco_string_contains(dir, '\0')) {
 		g_set_error_literal(error, TECO_ERROR, TECO_ERROR_FAILED,
 		                    "Directory contains null-character");
 		return FALSE;
@@ -1107,7 +1107,7 @@ teco_qreg_table_get_environ(teco_qreg_table_t *table, GError **error)
 	for (teco_qreg_t *cur = first;
 	     cur && cur->head.name.data[0] == '$';
 	     cur = (teco_qreg_t *)teco_rb3str_get_next(&cur->head)) {
-		const teco_string_t *name = &cur->head.name;
+		const teco_string_t name = cur->head.name;
 
 		/*
 		 * Ignore the "$" register (not an environment
@@ -1115,7 +1115,7 @@ teco_qreg_table_get_environ(teco_qreg_table_t *table, GError **error)
 		 * name contains "=" or null (not allowed in environment
 		 * variable names).
 		 */
-		if (name->len == 1 ||
+		if (name.len == 1 ||
 		    teco_string_contains(name, '=') || teco_string_contains(name, '\0'))
 			continue;
 
@@ -1124,16 +1124,16 @@ teco_qreg_table_get_environ(teco_qreg_table_t *table, GError **error)
 			g_strfreev(envp);
 			return NULL;
 		}
-		if (teco_string_contains(&value, '\0')) {
+		if (teco_string_contains(value, '\0')) {
 			g_strfreev(envp);
 			g_set_error(error, TECO_ERROR, TECO_ERROR_FAILED,
 			            "Environment register \"%s\" must not contain null characters",
-			            name->data);
+			            name.data);
 			return NULL;
 		}
 
 		/* more efficient than g_environ_setenv() */
-		*p++ = g_strconcat(name->data+1, "=", value.data, NULL);
+		*p++ = g_strconcat(name.data+1, "=", value.data, NULL);
 	}
 
 	*p = NULL;
@@ -1439,7 +1439,7 @@ teco_state_qregspec_start_input(teco_machine_qregspec_t *ctx, gunichar chr, GErr
 /* in cmdline.c */
 gboolean teco_state_qregspec_process_edit_cmd(teco_machine_qregspec_t *ctx, teco_machine_t *parent_ctx,
                                               gunichar key, GError **error);
-gboolean teco_state_qregspec_insert_completion(teco_machine_qregspec_t *ctx, const teco_string_t *str,
+gboolean teco_state_qregspec_insert_completion(teco_machine_qregspec_t *ctx, teco_string_t str,
                                                GError **error);
 
 static TECO_DEFINE_STATE(teco_state_qregspec_start,
@@ -1587,7 +1587,7 @@ teco_state_qregspec_string_input(teco_machine_qregspec_t *ctx, gunichar chr, GEr
 /* in cmdline.c */
 gboolean teco_state_qregspec_string_process_edit_cmd(teco_machine_qregspec_t *ctx, teco_machine_t *parent_ctx,
                                                      gunichar key, GError **error);
-gboolean teco_state_qregspec_string_insert_completion(teco_machine_qregspec_t *ctx, const teco_string_t *str,
+gboolean teco_state_qregspec_string_insert_completion(teco_machine_qregspec_t *ctx, teco_string_t str,
                                                       GError **error);
 
 static TECO_DEFINE_STATE(teco_state_qregspec_string,