teco_string_t is now passed by value like a scalar if the callee isn't expected to modify it

* When passing a struct that should not be modified, I usually use a const pointer.
* Strings however are small 2-word objects and they are often now already passed via separate
  `gchar*` and gsize parameters. So it is consistent to pass teco_string_t by value as well.
  A teco_string_t will usually fit into registers just like a pointer.
* It's now obvious which function just _uses_ and which function _modifies_ a string.
  There is also no chance to pass a NULL pointer to those functions.

1 files changed, 4 insertions, 4 deletions

diff --git a/src/spawn.c b/src/spawn.c
index 6745b4f..43dac15 100644
--- a/src/spawn.c
+++ b/src/spawn.c
@@ -150,7 +150,7 @@ teco_parse_shell_command_line(const gchar *cmdline, GError **error)
 		teco_string_t shell;
 		if (!reg->vtable->get_string(reg, &shell.data, &shell.len, NULL, error))
 			return NULL;
-		if (teco_string_contains(&shell, '\0')) {
+		if (teco_string_contains(shell, '\0')) {
 			teco_string_clear(&shell);
 			teco_error_qregcontainsnull_set(error, "$SHELL", 6, FALSE);
 			return NULL;
@@ -242,7 +242,7 @@ teco_state_execute_initial(teco_machine_main_t *ctx, GError **error)
 }
 
 static teco_state_t *
-teco_state_execute_done(teco_machine_main_t *ctx, const teco_string_t *str, GError **error)
+teco_state_execute_done(teco_machine_main_t *ctx, teco_string_t str, GError **error)
 {
 	/*
 	 * NOTE: With G_SPAWN_LEAVE_DESCRIPTORS_OPEN and without G_SPAWN_SEARCH_PATH_FROM_ENVP,
@@ -285,13 +285,13 @@ teco_state_execute_done(teco_machine_main_t *ctx, const teco_string_t *str, GErr
 	}
 #endif
 
-	if (!str->len || teco_string_contains(str, '\0')) {
+	if (!str.len || teco_string_contains(str, '\0')) {
 		g_set_error(error, TECO_ERROR, TECO_ERROR_FAILED,
 		            "Command line must not be empty or contain null-bytes");
 		goto gerror;
 	}
 
-	argv = teco_parse_shell_command_line(str->data, error);
+	argv = teco_parse_shell_command_line(str.data, error);
 	if (!argv)
 		goto gerror;