diff options
| author | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2022-11-28 06:05:48 +0300 |
|---|---|---|
| committer | Robin Haberkorn <robin.haberkorn@googlemail.com> | 2022-11-28 06:05:48 +0300 |
| commit | 9a20db4b5257d56d2d6030a20ad42f5e0dc9f25b (patch) | |
| tree | 194d28409d2e4e5e15ed172b16c8ff5396cd2fb7 /src/symbols.c | |
| parent | 9c789e80407cdfe3f5f7d2feb8e77bdeb130b78a (diff) | |
| download | sciteco-9a20db4b5257d56d2d6030a20ad42f5e0dc9f25b.tar.gz | |
fixed a number of crashes due to empty string arguments or uninitialized registers
* An empty but valid teco_string_t can contain NULL pointers.
More precisely, a state's done_cb() can be invoked with such empty strings
in case of empty string arguments.
Also a registers get_string() can return the NULL pointer
for existing registers with uninitialized string parts.
* In all of these cases, the language should treat "uninitialized" strings
exactly like empty strings.
* Not doing so, resulted in a number of vulnerabilities.
* EN$$ crashed if "_" was uninitialized
* The ^E@q and ^ENq string building constructs would crash for existing but
uninitialized registers q.
* ?$ would crash
* ESSETILEXER$$ would crash
* This is now fixed.
Test cases have been added.
* I cannot guarantee that I have found all such cases.
Generally, it might be wise to change our definitions and make sure that
every teco_string_t must have an associated heap object to be valid.
All functions returning pointer+length pairs should consequently also never
return NULL pointers.
Diffstat (limited to 'src/symbols.c')
| -rw-r--r-- | src/symbols.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/symbols.c b/src/symbols.c index 015b933..ac67662 100644 --- a/src/symbols.c +++ b/src/symbols.c @@ -326,10 +326,11 @@ teco_state_scintilla_lparam_done(teco_machine_main_t *ctx, const teco_string_t * return NULL; } - lParam = (sptr_t)CreateLexer(str->data); + const gchar *lexer = str->data ? : ""; + lParam = (sptr_t)CreateLexer(lexer); if (!lParam) { g_set_error(error, TECO_ERROR, TECO_ERROR_FAILED, - "Lexilla lexer \"%s\" not found.", str->data); + "Lexilla lexer \"%s\" not found.", lexer); return NULL; } } else if (str->len > 0) { |