teco_string_t is now passed by value like a scalar if the callee isn't expected to modify it

* When passing a struct that should not be modified, I usually use a const pointer.
* Strings however are small 2-word objects and they are often now already passed via separate
  `gchar*` and gsize parameters. So it is consistent to pass teco_string_t by value as well.
  A teco_string_t will usually fit into registers just like a pointer.
* It's now obvious which function just _uses_ and which function _modifies_ a string.
  There is also no chance to pass a NULL pointer to those functions.

1 files changed, 20 insertions, 20 deletions

diff --git a/src/symbols.c b/src/symbols.c
index caae09a..9c76183 100644
--- a/src/symbols.c
+++ b/src/symbols.c
@@ -139,7 +139,7 @@ teco_symbol_list_auto_complete(teco_symbol_list_t *ctx, const gchar *symbol, tec
 		glist_str.data = (gchar *)glist->data + symbol_len;
 		glist_str.len = strlen(glist_str.data);
 
-		gsize len = teco_string_casediff(&glist_str, (gchar *)entry->data + symbol_len,
+		gsize len = teco_string_casediff(glist_str, (gchar *)entry->data + symbol_len,
 		                                 strlen(entry->data) - symbol_len);
 		if (!prefix_len || len < prefix_len)
 			prefix_len = len;
@@ -177,7 +177,7 @@ teco_scintilla_ssm(unsigned int iMessage, uptr_t wParam, sptr_t lParam)
 static teco_state_t teco_state_scintilla_lparam;
 
 static gboolean
-teco_scintilla_parse_symbols(teco_machine_scintilla_t *scintilla, const teco_string_t *str, GError **error)
+teco_scintilla_parse_symbols(teco_machine_scintilla_t *scintilla, teco_string_t str, GError **error)
 {
 	if (teco_string_contains(str, '\0')) {
 		g_set_error_literal(error, TECO_ERROR, TECO_ERROR_FAILED,
@@ -185,7 +185,7 @@ teco_scintilla_parse_symbols(teco_machine_scintilla_t *scintilla, const teco_str
 		return FALSE;
 	}
 
-	g_auto(GStrv) symbols = g_strsplit(str->data, ",", -1);
+	g_auto(GStrv) symbols = g_strsplit(str.data, ",", -1);
 
 	if (!symbols[0])
 		return TRUE;
@@ -217,7 +217,7 @@ teco_scintilla_parse_symbols(teco_machine_scintilla_t *scintilla, const teco_str
 }
 
 static teco_state_t *
-teco_state_scintilla_symbols_done(teco_machine_main_t *ctx, const teco_string_t *str, GError **error)
+teco_state_scintilla_symbols_done(teco_machine_main_t *ctx, teco_string_t str, GError **error)
 {
 	if (ctx->flags.mode > TECO_MODE_NORMAL)
 		return &teco_state_scintilla_lparam;
@@ -231,7 +231,7 @@ teco_state_scintilla_symbols_done(teco_machine_main_t *ctx, const teco_string_t
 		teco_undo_scintilla_message(ctx->scintilla);
 	memset(&ctx->scintilla, 0, sizeof(ctx->scintilla));
 
-	if ((str->len > 0 && !teco_scintilla_parse_symbols(&ctx->scintilla, str, error)) ||
+	if ((str.len > 0 && !teco_scintilla_parse_symbols(&ctx->scintilla, str, error)) ||
 	    !teco_expressions_eval(FALSE, error))
 		return NULL;
 
@@ -251,7 +251,7 @@ teco_state_scintilla_symbols_done(teco_machine_main_t *ctx, const teco_string_t
 /* in cmdline.c */
 gboolean teco_state_scintilla_symbols_process_edit_cmd(teco_machine_main_t *ctx, teco_machine_t *parent_ctx,
                                                        gunichar key, GError **error);
-gboolean teco_state_scintilla_symbols_insert_completion(teco_machine_main_t *ctx, const teco_string_t *str,
+gboolean teco_state_scintilla_symbols_insert_completion(teco_machine_main_t *ctx, teco_string_t str,
                                                         GError **error);
 
 /*$ ES scintilla message
@@ -359,11 +359,11 @@ TECO_DEFINE_STATE_EXPECTSTRING(teco_state_scintilla_symbols,
 #ifdef HAVE_LEXILLA
 
 static gpointer
-teco_create_lexer(const teco_string_t *str, GError **error)
+teco_create_lexer(teco_string_t str, GError **error)
 {
 	CreateLexerFn CreateLexerFn = CreateLexer;
 
-	const gchar *lexer = memchr(str->data ? : "", '\0', str->len);
+	const gchar *lexer = memchr(str.data ? : "", '\0', str.len);
 	if (lexer) {
 		/* external lexer */
 		lexer++;
@@ -372,7 +372,7 @@ teco_create_lexer(const teco_string_t *str, GError **error)
 		 * NOTE: The same module can be opened multiple times.
 		 * They are internally reference counted.
 		 */
-		GModule *module = g_module_open(str->data, G_MODULE_BIND_LAZY);
+		GModule *module = g_module_open(str.data, G_MODULE_BIND_LAZY);
 		if (!module) {
 			teco_error_module_set(error, "Error opening lexer module");
 			return NULL;
@@ -394,7 +394,7 @@ teco_create_lexer(const teco_string_t *str, GError **error)
 			 *
 			 * FIXME: In Scintillua distributions, the lexers are usually contained in the
 			 * same directory as the prebuilt shared libraries.
-			 * Perhaps we should default scintillua.lexers to the dirname in str->data?
+			 * Perhaps we should default scintillua.lexers to the dirname in str.data?
 			 */
 			teco_qreg_t *reg = teco_qreg_table_find(&teco_qreg_table_globals, "$SCITECO_SCINTILLUA_LEXERS", 26);
 			if (reg) {
@@ -406,7 +406,7 @@ teco_create_lexer(const teco_string_t *str, GError **error)
 		}
 	} else {
 		/* Lexilla lexer */
-		lexer = str->data ? : "";
+		lexer = str.data ? : "";
 	}
 
 	ILexer5 *ret = CreateLexerFn(lexer);
@@ -422,9 +422,9 @@ teco_create_lexer(const teco_string_t *str, GError **error)
 #else /* !HAVE_LEXILLA */
 
 static gpointer
-teco_create_lexer(const teco_string_t *str, GError **error)
+teco_create_lexer(teco_string_t str, GError **error)
 {
-	g_autofree gchar *str_printable = teco_string_echo(str->data, str->len);
+	g_autofree gchar *str_printable = teco_string_echo(str.data, str.len);
 	g_set_error(error, TECO_ERROR, TECO_ERROR_FAILED,
 	            "Cannot load lexer \"%s\": Lexilla disabled", str_printable);
 	return NULL;
@@ -433,7 +433,7 @@ teco_create_lexer(const teco_string_t *str, GError **error)
 #endif
 
 static teco_state_t *
-teco_state_scintilla_lparam_done(teco_machine_main_t *ctx, const teco_string_t *str, GError **error)
+teco_state_scintilla_lparam_done(teco_machine_main_t *ctx, teco_string_t str, GError **error)
 {
 	if (ctx->flags.mode > TECO_MODE_NORMAL)
 		return &teco_state_start;
@@ -466,13 +466,13 @@ teco_state_scintilla_lparam_done(teco_machine_main_t *ctx, const teco_string_t *
 		}
 
 		g_set_error(error, TECO_ERROR, TECO_ERROR_FAILED,
-		            "Style name \"%s\" not found.", str->data ? : "");
+		            "Style name \"%s\" not found.", str.data ? : "");
 		return NULL;
 	} else if (ctx->scintilla.iMessage == SCI_SETILEXER) {
 		lParam = (sptr_t)teco_create_lexer(str, error);
 		if (!lParam)
 			return NULL;
-	} else if (str->len > 0) {
+	} else if (str.len > 0) {
 		/*
 		 * Theoretically, Scintilla could use null bytes from the string specified.
 		 * This could only be the case for messages where the string length is
@@ -482,13 +482,13 @@ teco_state_scintilla_lparam_done(teco_machine_main_t *ctx, const teco_string_t *
 		 * which unlocks useful messages like
 		 * SCI_SETREPRESENTATIONS and SCI_SETPROPERTY.
 		 */
-		const gchar *p = memchr(str->data, '\0', str->len);
+		const gchar *p = memchr(str.data, '\0', str.len);
 		if (p) {
-			ctx->scintilla.wParam = (uptr_t)str->data;
-			if (str->len > p - str->data + 1)
+			ctx->scintilla.wParam = (uptr_t)str.data;
+			if (str.len > p - str.data + 1)
 				lParam = (sptr_t)(p+1);
 		} else {
-			lParam = (sptr_t)str->data;
+			lParam = (sptr_t)str.data;
 		}
 	}